From patchwork Wed Jul 31 15:20:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 13748904 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7043B1BC072 for ; Wed, 31 Jul 2024 15:21:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722439266; cv=none; b=m76woJgX+ADZ/LKNyEgX4JeSQr7cGCtoMGsZLdDgPjpYjN4HxIocMXYZJOLvcuSj47WMuv+Wu5HvMhJhBIOuHGV77Rkx+u0lMiG+dIETy2/q8VgqNxddwPLBUPgTJqTKdXFo85yNfQidN1G2Cz5sNxWBiWPFDGgdXNwSglJPU88= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722439266; c=relaxed/simple; bh=mnsFfjsXyLCpcHqVRuLDx+XTYSAgSLLlD1CQjdlWwhI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=l10fN/8RpjEOFgWSo7dsL+p7YpcirpMjvgb1WIBbGRI/K49Actv203IQZ0+e2Q4Y2XtQj6s+gPeGhhSeFqFBwrA086aD2ssEOOjYWJIBt/8r6oYWnTquu5W1bP8fl74rTpz14N/4KvGzMi3r2dos2GZKcRm173HwsIcpmZT03sU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=xk2smTWr; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="xk2smTWr" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-42817f1eb1fso33118055e9.1 for ; Wed, 31 Jul 2024 08:21:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1722439263; x=1723044063; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=PPgFx6S9AzTv/56jUbfitvD1CUFmclbA7VamQiWR1as=; b=xk2smTWrgNVg9aojipP3TqIeLQj0GJwwm458mp/dGVmRiDCD/UzeXcs6k0+QWIKQ7A brNPI4EjxSQAyoCB3jhll5J8n2hNXqDYl47YOwimSaQTEeTMsSIH55ZbN8Dja2wmeYqC AfpoyUYPVXZLqMlGZOY1rX7laSwQMni5UmWfDUIm5SopDxdu1aCVQMM/vw3EnQM5CkEH AFmUEkD6R+L3tVGhBGMNl0juL75XCVmmPwRDJQ7jWkdhD0TFPORzf/2kUX2OT32462Vl y/3est4KEJYK1pE3arESLWF+bKU8014sFsDUCG0UOoAetykres9iNFXOu0V3PIuE4MFF V0MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722439263; x=1723044063; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PPgFx6S9AzTv/56jUbfitvD1CUFmclbA7VamQiWR1as=; b=lEMXx9XhyXRQzb/KZGofUyTkhcFnzwKhBfvmm6KSpCGgDfaFYOhDuYYLzBEyLqNc4z gff6s8pcp90NTFShpMAc0uL9kH+ALw5wVSwJdQ6DeCcY2L3OEzkWeQt/uDDvGBpB/DzP T7+67a1e1svTYmkSajkdLhu0b8H5xu696ax+3Nq5MNKsbLnln2sPbVsWd3ASQlsIYoOr BwwZZLVSGGQQInFMlj/ayN7acREL1ZnE9sA42ATBYyiC0m7cKlljCA02rTRcXNlIlnIs 2pZzzqMVNghPwbFgmurNuWFAPJoWta5GWtOnj8AbvANeCDrfq/DW34Q5Gv/pFqP2Nm0l p9Pg== X-Forwarded-Encrypted: i=1; AJvYcCXvf7o4KvScmYZfBIFXEZAEy2Nap5R+sgnY05FfA+nKNygoevACsS7BZ1+jusfBwTtfH43ViaqX9cRcoaf6fLc=@vger.kernel.org X-Gm-Message-State: AOJu0YxLGUTIj6/iVoS/Td6wrcQtAKf9aY3iBLi27XcL+7DuHg/igc0i eWYVpyjxLPrdmWIQcKIKCIrfRfqc0ryV7Jsmj4R36Jdby03DBWX4n3tAvG0+YcQ= X-Google-Smtp-Source: AGHT+IHClkBhl81RbhbhQwvb71V6F2Gv1oAzwjiUmbWV0cXrXma4jczdTf7X7a33LPe5bCg9giE3HA== X-Received: by 2002:a05:600c:46c8:b0:427:d8f2:550 with SMTP id 5b1f17b1804b1-42811d9a644mr114725735e9.14.1722439262498; Wed, 31 Jul 2024 08:21:02 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:9c3f:3dd8:b524:cb31]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4282b8addd6sm24752925e9.20.2024.07.31.08.21.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Jul 2024 08:21:02 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 31 Jul 2024 17:20:49 +0200 Subject: [PATCH 2/3] Bluetooth: hci_qca: fix QCA6390 support on non-DT platforms Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240731-hci_qca_fixes-v1-2-59dad830b243@linaro.org> References: <20240731-hci_qca_fixes-v1-0-59dad830b243@linaro.org> In-Reply-To: <20240731-hci_qca_fixes-v1-0-59dad830b243@linaro.org> To: Marcel Holtmann , Luiz Augusto von Dentz , Wren Turkal , Dmitry Baryshkov Cc: Luiz Augusto von Dentz , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1545; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=Ga1opdpymbhkU9R1JhuG60TILNDZdSmzqdrgmgVV3PI=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBmqlZcBgQ6G7JKZlOYHDPZ6H9v/UOairIpBeC8C LZhczsp6YCJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZqpWXAAKCRARpy6gFHHX chMRD/9i9QXxsGdNawfMfGnpI37fW2Bx2vn/GP0x74mQ7mLMd9rVGpghAT6q8wJABaq/BreCtJm woeGTIGsKJOFPdWfCrCOAO/F6v+7UQisQt9RGhmXL0elSElvZ3HL+N1dPAo7KOtDuJEiqnirv9P 6k7G68nqPIigIOFnIVCD/yAWISkFO6c/NroAiAbkX7eg/mJAUOATw3v4VzjpzTWSJxDL502F4gE M8hNuUxnTEBt77oXJ9QO2gEpCW1mEsnnSSiDQ8PiXGjcPBamc6Ny1yqCXLljW3ybOzeBdhFsdzX afObt8+b4GtCy0G5e6ntJnUhKdApNXkVy4FWiUQwSLE5ko0g5vqiuFlhlvNC28fyPxxR+qp4WhL q3SMhsC7F58hngvZrVhmaudsLBjwzuun6FZKCBOUi9Oo494dEzyYv/ogkMRc3oYtXXIiUAJ4vb1 mIoH+pUmzJBWP/EUqNUzqAXAMCwEWvYTOnRQyfCbmczcGYxJJrR2lj8xZXGFpbOnRHhrn2jJhcZ t0nzkdD8a05VjCFCeNIBvdt9T2s5e38xLVq3RJGGl6P6hNjAYGn3N3Fk34fJh4x96ir8koBHtge 8+J5pRv4uC0MhxHEcYbr+wPNMN+PwY8b1zE3PzRWPIdnHn0NQiwiruA/AqELTEkkDoiey43lOiH WPjjqlrdt242VwA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski QCA6390 can albo be used on non-DT systems so we must not make the power sequencing the only option. Check if the serdev device consumes an OF node. If so: honor the new contract as per the DT bindings. If not: fall back to the previous behavior by falling through to the existing default label. Fixes: 9a15ce685706 ("Bluetooth: qca: use the power sequencer for QCA6390") Reported-by: Wren Turkal Closes: https://lore.kernel.org/linux-bluetooth/27e6a6c5-fb63-4219-be0b-eefa2c116e06@penguintechs.org/ Signed-off-by: Bartosz Golaszewski Reviewed-by: Paul Menzel Tested-by: (...) --- drivers/bluetooth/hci_qca.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index a20dd5015346..2baed7d0f479 100644 --- a/drivers/bluetooth/hci_qca.c +++ b/drivers/bluetooth/hci_qca.c @@ -2412,11 +2412,14 @@ static int qca_serdev_probe(struct serdev_device *serdev) break; case QCA_QCA6390: - qcadev->bt_power->pwrseq = devm_pwrseq_get(&serdev->dev, - "bluetooth"); - if (IS_ERR(qcadev->bt_power->pwrseq)) - return PTR_ERR(qcadev->bt_power->pwrseq); - break; + if (dev_of_node(&serdev->dev)) { + qcadev->bt_power->pwrseq = devm_pwrseq_get(&serdev->dev, + "bluetooth"); + if (IS_ERR(qcadev->bt_power->pwrseq)) + return PTR_ERR(qcadev->bt_power->pwrseq); + break; + } + fallthrough; default: qcadev->bt_en = devm_gpiod_get_optional(&serdev->dev, "enable",