Bluetooth: btusb: Add USB HW ID for ASUS Zenbook S 16.

Commit Message

Bas Nieuwenhuizen Aug. 4, 2024, 7:53 p.m. UTC

Variant UM5605WA,  which uses MT7925 with this device. With
this patch I was able to pair my earbuds. I don't know what
other testing is needed here.

Signed-off-by: Bas Nieuwenhuizen <[e-mail]>
---
 drivers/bluetooth/btusb.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

[e-mail] Aug. 4, 2024, 8:36 p.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=876531

---Test result---

Test Summary:
CheckPatch                    PASS      10.04 seconds
GitLint                       FAIL      0.46 seconds
SubjectPrefix                 PASS      0.09 seconds
BuildKernel                   PASS      29.88 seconds
CheckAllWarning               PASS      32.21 seconds
CheckSparse                   PASS      50.88 seconds
CheckSmatch                   PASS      102.27 seconds
BuildKernel32                 PASS      29.31 seconds
TestRunnerSetup               PASS      531.84 seconds
TestRunner_l2cap-tester       PASS      19.96 seconds
TestRunner_iso-tester         PASS      31.67 seconds
TestRunner_bnep-tester        PASS      5.11 seconds
TestRunner_mgmt-tester        FAIL      121.30 seconds
TestRunner_rfcomm-tester      PASS      7.36 seconds
TestRunner_sco-tester         PASS      15.01 seconds
TestRunner_ioctl-tester       PASS      7.86 seconds
TestRunner_mesh-tester        PASS      5.97 seconds
TestRunner_smp-tester         PASS      6.88 seconds
TestRunner_userchan-tester    PASS      5.01 seconds
IncrementalBuild              PASS      27.72 seconds

Details
##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
Bluetooth: btusb: Add USB HW ID for ASUS Zenbook S 16.

WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
1: T3 Title has trailing punctuation (.): "Bluetooth: btusb: Add USB HW ID for ASUS Zenbook S 16."
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 492, Passed: 489 (99.4%), Failed: 1, Not Run: 2

Failed Test Cases
LL Privacy - Remove Device 4 (Disable Adv)           Timed out    2.717 seconds


---
Regards,
Linux Bluetooth

Paul Menzel Aug. 5, 2024, 5:57 a.m. UTC | #2

Dear Bas,


Thank you for your patch. I’d mention Mediatek and remove the dot at the 
end in the commit message summary/title.


Am 04.08.24 um 21:53 schrieb Bas Nieuwenhuizen:
> Variant UM5605WA,  which uses MT7925 with this device. With

Just use one space after the comma?

> this patch I was able to pair my earbuds. I don't know what
> other testing is needed here.

I think it’s common to include the output of 
`/sys/kernel/debug/usb/devices`.

> Signed-off-by: Bas Nieuwenhuizen <[e-mail]>
> ---
>   drivers/bluetooth/btusb.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index 789c492df6fa..b5fdc0f3c341 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -695,6 +695,10 @@ static const struct usb_device_id quirks_table[] = {
>   	{ USB_DEVICE(0x13d3, 0x3603), .driver_info = BTUSB_MEDIATEK |
>   						     BTUSB_WIDEBAND_SPEECH |
>   						     BTUSB_VALID_LE_STATES },
> +	{ USB_DEVICE(0x13d3, 0x3608), .driver_info = BTUSB_MEDIATEK |
> +						     BTUSB_WIDEBAND_SPEECH |
> +						     BTUSB_VALID_LE_STATES },
> +
>   
>   	/* Additional Realtek 8723AE Bluetooth devices */
>   	{ USB_DEVICE(0x0930, 0x021d), .driver_info = BTUSB_REALTEK },

I just noticed that Nuclear Sunshine sent the same diff [1].


Kind regards,

Paul


[1]: 
https://lore.kernel.org/all/[e-mail]/

Patch

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 789c492df6fa..b5fdc0f3c341 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -695,6 +695,10 @@  static const struct usb_device_id quirks_table[] = {
 	{ USB_DEVICE(0x13d3, 0x3603), .driver_info = BTUSB_MEDIATEK |
 						     BTUSB_WIDEBAND_SPEECH |
 						     BTUSB_VALID_LE_STATES },
+	{ USB_DEVICE(0x13d3, 0x3608), .driver_info = BTUSB_MEDIATEK |
+						     BTUSB_WIDEBAND_SPEECH |
+						     BTUSB_VALID_LE_STATES },
+
 
 	/* Additional Realtek 8723AE Bluetooth devices */
 	{ USB_DEVICE(0x0930, 0x021d), .driver_info = BTUSB_REALTEK },