diff mbox series

[BlueZ,v1,2/3] android/avctp: remove check in session_browsing_cb()

Message ID 20240809162252.50098-3-r.smirnov@omp.ru (mailing list archive)
State Accepted
Commit 19ff9ab9151205501025a8bd061da022bb44bd58
Headers show
Series fix errors found by SVACE static analyzer #4 | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/CheckPatch success CheckPatch PASS
tedd_an/GitLint success Gitlint PASS
tedd_an/IncrementalBuild success Incremental Build PASS

Commit Message

Roman Smirnov Aug. 9, 2024, 4:22 p.m. UTC 
session->browsing is dereferenced at the beginning of the function, so
the check can be removed.

Found with the SVACE static analysis tool.
---
 android/avctp.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
diff mbox series

Patch

diff --git a/android/avctp.c b/android/avctp.c
index 37b4cec4f..d8104a7c2 100644
--- a/android/avctp.c
+++ b/android/avctp.c
@@ -905,10 +905,8 @@  send:
 failed:
 	DBG("AVCTP Browsing: disconnected");
 
-	if (session->browsing) {
-		avctp_channel_destroy(session->browsing);
-		session->browsing = NULL;
-	}
+	avctp_channel_destroy(session->browsing);
+	session->browsing = NULL;
 
 	return FALSE;
 }