diff mbox series

[BlueZ,v1,1/2] device: Promote Device.{AdvertisingData, AdvertisingFlags} to stable

Message ID 20240814185714.844117-1-luiz.dentz@gmail.com (mailing list archive)
State Accepted
Commit c315b42e053892e623dc8a755a278d369d910291
Headers show
Series [BlueZ,v1,1/2] device: Promote Device.{AdvertisingData, AdvertisingFlags} to stable | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/CheckPatch success CheckPatch PASS
tedd_an/GitLint fail WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search 1: T1 Title exceeds max length (83>80): "[BlueZ,v1,1/2] device: Promote Device.{AdvertisingData, AdvertisingFlags} to stable"
tedd_an/BuildEll success Build ELL PASS
tedd_an/BluezMake success Bluez Make PASS
tedd_an/MakeCheck success Bluez Make Check PASS
tedd_an/MakeDistcheck success Make Distcheck PASS
tedd_an/CheckValgrind success Check Valgrind PASS
tedd_an/CheckSmatch success CheckSparse PASS
tedd_an/bluezmakeextell success Make External ELL PASS
tedd_an/IncrementalBuild success Incremental Build PASS
tedd_an/ScanBuild success Scan Build PASS

Commit Message

Luiz Augusto von Dentz Aug. 14, 2024, 6:57 p.m. UTC
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

This promotes AdvertisingData and AdvertisingFlags to stable so they can
be used by upper layers without having to enable experimental.
---
 doc/org.bluez.Device.rst | 8 ++++----
 src/device.c             | 6 ++----
 2 files changed, 6 insertions(+), 8 deletions(-)

Comments

bluez.test.bot@gmail.com Aug. 14, 2024, 9:05 p.m. UTC | #1
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=879759

---Test result---

Test Summary:
CheckPatch                    FAIL      1.12 seconds
GitLint                       FAIL      0.83 seconds
BuildEll                      PASS      24.71 seconds
BluezMake                     PASS      1685.96 seconds
MakeCheck                     PASS      13.60 seconds
MakeDistcheck                 PASS      177.24 seconds
CheckValgrind                 PASS      253.55 seconds
CheckSmatch                   PASS      355.97 seconds
bluezmakeextell               PASS      119.79 seconds
IncrementalBuild              PASS      3048.70 seconds
ScanBuild                     PASS      992.60 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[BlueZ,v1,2/2] adapter: Create devices if they are connectable
WARNING:UNKNOWN_COMMIT_ID: Unknown commit id '815f779aa8e4', maybe rebased or not pulled?
#99: 
or not and bluetoothctl has been using it since commit 815f779aa8e4

/github/workspace/src/src/13763849.patch total: 0 errors, 1 warnings, 8 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/src/13763849.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
[BlueZ,v1,1/2] device: Promote Device.{AdvertisingData, AdvertisingFlags} to stable

WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
1: T1 Title exceeds max length (83>80): "[BlueZ,v1,1/2] device: Promote Device.{AdvertisingData, AdvertisingFlags} to stable"


---
Regards,
Linux Bluetooth
patchwork-bot+bluetooth@kernel.org Aug. 15, 2024, 7:40 p.m. UTC | #2
Hello:

This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Wed, 14 Aug 2024 14:57:13 -0400 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> This promotes AdvertisingData and AdvertisingFlags to stable so they can
> be used by upper layers without having to enable experimental.
> ---
>  doc/org.bluez.Device.rst | 8 ++++----
>  src/device.c             | 6 ++----
>  2 files changed, 6 insertions(+), 8 deletions(-)

Here is the summary with links:
  - [BlueZ,v1,1/2] device: Promote Device.{AdvertisingData, AdvertisingFlags} to stable
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=c315b42e0538
  - [BlueZ,v1,2/2] adapter: Create devices if they are connectable
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=939133293829

You are awesome, thank you!
diff mbox series

Patch

diff --git a/doc/org.bluez.Device.rst b/doc/org.bluez.Device.rst
index 4fdb31b0acbe..f94fc21296a9 100644
--- a/doc/org.bluez.Device.rst
+++ b/doc/org.bluez.Device.rst
@@ -293,13 +293,13 @@  bool ServicesResolved [readonly]
 
 	Indicate whether or not service discovery has been resolved.
 
-array{byte} AdvertisingFlags [readonly, experimental]
-`````````````````````````````````````````````````````
+array{byte} AdvertisingFlags [readonly]
+```````````````````````````````````````
 
 	The Advertising Data Flags of the remote device.
 
-dict AdvertisingData [readonly, experimental]
-`````````````````````````````````````````````
+dict AdvertisingData [readonly]
+```````````````````````````````
 
 	The Advertising Data of the remote device. Keys are 1 byte AD Type
 	followed by data as byte array.
diff --git a/src/device.c b/src/device.c
index cf7264051ac2..1a5e8a7caa27 100644
--- a/src/device.c
+++ b/src/device.c
@@ -3252,11 +3252,9 @@  static const GDBusPropertyTable device_properties[] = {
 					dev_property_exists_tx_power },
 	{ "ServicesResolved", "b", dev_property_get_svc_resolved, NULL, NULL },
 	{ "AdvertisingFlags", "ay", dev_property_get_flags, NULL,
-					dev_property_flags_exist,
-					G_DBUS_PROPERTY_FLAG_EXPERIMENTAL},
+					dev_property_flags_exist },
 	{ "AdvertisingData", "a{yv}", dev_property_get_advertising_data,
-				NULL, dev_property_advertising_data_exist,
-				G_DBUS_PROPERTY_FLAG_EXPERIMENTAL },
+				NULL, dev_property_advertising_data_exist },
 	{ "WakeAllowed", "b", dev_property_get_wake_allowed,
 				dev_property_set_wake_allowed,
 				dev_property_wake_allowed_exist },