diff mbox series

[BlueZ,1/1] att: Correctly handle negative return values in can_write_data

Message ID 20240827080925.55684-1-xiaokeqinhealth@126.com (mailing list archive)
State Accepted
Commit 32a0811685c5dd290f1152bef2dfbde3b2848446
Headers show
Series [BlueZ,1/1] att: Correctly handle negative return values in can_write_data | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/CheckPatch success CheckPatch PASS
tedd_an/GitLint success Gitlint PASS
tedd_an/BuildEll success Build ELL PASS
tedd_an/BluezMake success Bluez Make PASS
tedd_an/MakeCheck success Bluez Make Check PASS
tedd_an/MakeDistcheck success Make Distcheck PASS
tedd_an/CheckValgrind success Check Valgrind PASS
tedd_an/CheckSmatch success CheckSparse PASS
tedd_an/bluezmakeextell success Make External ELL PASS
tedd_an/IncrementalBuild success Incremental Build PASS
tedd_an/ScanBuild success Scan Build PASS

Commit Message

Yao Xiao Aug. 27, 2024, 8:09 a.m. UTC
From: Felix Qin <xiaoyao@rock-chips.com>

---
 src/shared/att.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

bluez.test.bot@gmail.com Aug. 27, 2024, 9:54 a.m. UTC | #1
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=883691

---Test result---

Test Summary:
CheckPatch                    PASS      0.45 seconds
GitLint                       PASS      0.32 seconds
BuildEll                      PASS      25.24 seconds
BluezMake                     PASS      1776.12 seconds
MakeCheck                     PASS      13.66 seconds
MakeDistcheck                 PASS      197.53 seconds
CheckValgrind                 PASS      271.73 seconds
CheckSmatch                   PASS      359.10 seconds
bluezmakeextell               PASS      121.55 seconds
IncrementalBuild              PASS      1697.00 seconds
ScanBuild                     PASS      1172.61 seconds



---
Regards,
Linux Bluetooth
patchwork-bot+bluetooth@kernel.org Aug. 28, 2024, 6:20 p.m. UTC | #2
Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Tue, 27 Aug 2024 16:09:25 +0800 you wrote:
> From: Felix Qin <xiaoyao@rock-chips.com>
> 
> ---
>  src/shared/att.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - [BlueZ,1/1] att: Correctly handle negative return values in can_write_data
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=32a0811685c5

You are awesome, thank you!
diff mbox series

Patch

diff --git a/src/shared/att.c b/src/shared/att.c
index a45e9c268..4a406f4b9 100644
--- a/src/shared/att.c
+++ b/src/shared/att.c
@@ -551,7 +551,7 @@  static bool can_write_data(struct io *io, void *user_data)
 	if (!op)
 		return false;
 
-	if (!bt_att_chan_write(chan, op->opcode, op->pdu, op->len)) {
+	if (bt_att_chan_write(chan, op->opcode, op->pdu, op->len) < 0) {
 		if (op->callback)
 			op->callback(BT_ATT_OP_ERROR_RSP, NULL, 0,
 							op->user_data);