| Message ID | 20240827105248.18177-1-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 669e8c8b5663713009ea8c9c0c08bbd21e207267 |
| Headers | show |
| Series | [resend] Bluetooth: Use led_set_brightness() in LED trigger activate() callback | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/SubjectPrefix | success | Gitlint PASS |
| tedd_an/BuildKernel | success | BuildKernel PASS |
| tedd_an/CheckAllWarning | success | CheckAllWarning PASS |
| tedd_an/CheckSparse | success | CheckSparse PASS |
Hello: This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Tue, 27 Aug 2024 12:52:48 +0200 you wrote: > A LED trigger's activate() callback gets called when the LED trigger > gets activated for a specific LED, so that the trigger code can ensure > the LED state matches the current state of the trigger condition > (LED_FULL when HCI_UP is set in this case). > > led_trigger_event() is intended for trigger condition state changes and > iterates over _all_ LEDs which are controlled by this trigger changing > the brightness of each of them. > > [...] Here is the summary with links: - [resend] Bluetooth: Use led_set_brightness() in LED trigger activate() callback https://git.kernel.org/bluetooth/bluetooth-next/c/669e8c8b5663 You are awesome, thank you!
diff --git a/net/bluetooth/leds.c b/net/bluetooth/leds.c index f46847632ffa..6e349704efe4 100644 --- a/net/bluetooth/leds.c +++ b/net/bluetooth/leds.c @@ -48,7 +48,7 @@ static int power_activate(struct led_classdev *led_cdev) htrig = to_hci_basic_led_trigger(led_cdev->trigger); powered = test_bit(HCI_UP, &htrig->hdev->flags); - led_trigger_event(led_cdev->trigger, powered ? LED_FULL : LED_OFF); + led_set_brightness(led_cdev, powered ? LED_FULL : LED_OFF); return 0; }
A LED trigger's activate() callback gets called when the LED trigger gets activated for a specific LED, so that the trigger code can ensure the LED state matches the current state of the trigger condition (LED_FULL when HCI_UP is set in this case). led_trigger_event() is intended for trigger condition state changes and iterates over _all_ LEDs which are controlled by this trigger changing the brightness of each of them. In the activate() case only the brightness of the LED which is being activated needs to change and that LED is passed as an argument to activate(), switch to led_set_brightness() to only change the brightness of the LED being activated. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- net/bluetooth/leds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)