| Message ID | 20240915202320.8181-2-ismael@iodev.co.uk (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | cd1c6b666fa95555eeb3e43965c2b36106fa3694 |
| Headers | show |
| Series | Fix missing inclusion of <limits.h> | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | warning | CheckSparse WARNING monitor/att.c: note: in included file:monitor/display.h:82:26: warning: Variable length array is used. |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
| tedd_an/ScanBuild | warning | ScanBuild: emulator/serial.c:151:2: warning: Assigned value is garbage or undefined enum btdev_type uninitialized_var(type); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ emulator/serial.c:151:36: warning: Value stored to 'type' during its initialization is never read enum btdev_type uninitialized_var(type); ^~~~ emulator/serial.c:36:30: note: expanded from macro 'uninitialized_var' #define uninitialized_var(x) x = x ^ ~ emulator/serial.c:214:2: warning: Assigned value is garbage or undefined enum btdev_type uninitialized_var(dev_type); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ emulator/serial.c:214:36: warning: Value stored to 'dev_type' during its initialization is never read enum btdev_type uninitialized_var(dev_type); ^~~~~~~~ emulator/serial.c:36:30: note: expanded from macro 'uninitialized_var' #define uninitialized_var(x) x = x ^ ~ 4 warnings generated. profiles/audio/a2dp.c:372:8: warning: Use of memory after it is freed if (!cb->resume_cb) ^~~~~~~~~~~~~ 1 warning generated. src/gatt-database.c:1156:10: warning: Value stored to 'bits' during its initialization is never read uint8_t bits[] = { BT_GATT_CHRC_CLI_FEAT_ROBUST_CACHING, ^~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 warning generated. tools/bluemoon.c:1102:8: warning: Null pointer passed to 1st parameter expecting 'nonnull' if (strlen(optarg) > 3 && !strncmp(optarg, "hci", 3)) ^~~~~~~~~~~~~~ 1 warning generated. tools/hciattach.c:817:7: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n' if ((n = read_hci_event(fd, resp, 10)) < 0) { ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ tools/hciattach.c:865:7: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n' if ((n = read_hci_event(fd, resp, 4)) < 0) { ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~ tools/hciattach.c:887:8: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n' if ((n = read_hci_event(fd, resp, 10)) < 0) { ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ tools/hciattach.c:909:7: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n' if ((n = read_hci_event(fd, resp, 4)) < 0) { ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~ tools/hciattach.c:930:7: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n' if ((n = read_hci_event(fd, resp, 4)) < 0) { ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~ tools/hciattach.c:974:7: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n' if ((n = read_hci_event(fd, resp, 6)) < 0) { ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~ 6 warnings generated. |
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=890531
---Test result---
Test Summary:
CheckPatch PASS 0.41 seconds
GitLint PASS 0.29 seconds
BuildEll PASS 24.41 seconds
BluezMake PASS 1629.00 seconds
MakeCheck PASS 13.20 seconds
MakeDistcheck PASS 176.75 seconds
CheckValgrind PASS 250.36 seconds
CheckSmatch WARNING 352.20 seconds
bluezmakeextell PASS 119.12 seconds
IncrementalBuild PASS 1386.76 seconds
ScanBuild WARNING 982.79 seconds
Details
##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
monitor/att.c: note: in included file:monitor/display.h:82:26: warning: Variable length array is used.
##############################
Test: ScanBuild - WARNING
Desc: Run Scan Build
Output:
emulator/serial.c:151:2: warning: Assigned value is garbage or undefined
enum btdev_type uninitialized_var(type);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
emulator/serial.c:151:36: warning: Value stored to 'type' during its initialization is never read
enum btdev_type uninitialized_var(type);
^~~~
emulator/serial.c:36:30: note: expanded from macro 'uninitialized_var'
#define uninitialized_var(x) x = x
^ ~
emulator/serial.c:214:2: warning: Assigned value is garbage or undefined
enum btdev_type uninitialized_var(dev_type);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
emulator/serial.c:214:36: warning: Value stored to 'dev_type' during its initialization is never read
enum btdev_type uninitialized_var(dev_type);
^~~~~~~~
emulator/serial.c:36:30: note: expanded from macro 'uninitialized_var'
#define uninitialized_var(x) x = x
^ ~
4 warnings generated.
profiles/audio/a2dp.c:372:8: warning: Use of memory after it is freed
if (!cb->resume_cb)
^~~~~~~~~~~~~
1 warning generated.
src/gatt-database.c:1156:10: warning: Value stored to 'bits' during its initialization is never read
uint8_t bits[] = { BT_GATT_CHRC_CLI_FEAT_ROBUST_CACHING,
^~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
tools/bluemoon.c:1102:8: warning: Null pointer passed to 1st parameter expecting 'nonnull'
if (strlen(optarg) > 3 && !strncmp(optarg, "hci", 3))
^~~~~~~~~~~~~~
1 warning generated.
tools/hciattach.c:817:7: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n'
if ((n = read_hci_event(fd, resp, 10)) < 0) {
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/hciattach.c:865:7: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n'
if ((n = read_hci_event(fd, resp, 4)) < 0) {
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/hciattach.c:887:8: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n'
if ((n = read_hci_event(fd, resp, 10)) < 0) {
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/hciattach.c:909:7: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n'
if ((n = read_hci_event(fd, resp, 4)) < 0) {
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/hciattach.c:930:7: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n'
if ((n = read_hci_event(fd, resp, 4)) < 0) {
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/hciattach.c:974:7: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n'
if ((n = read_hci_event(fd, resp, 6)) < 0) {
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
6 warnings generated.
---
Regards,
Linux Bluetooth
Hello: This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Sun, 15 Sep 2024 22:23:20 +0200 you wrote: > Needed for PATH_MAX. > > Signed-off-by: Ismael Luceno <ismael@iodev.co.uk> > --- > android/ipc-tester.c | 1 + > android/system-emulator.c | 1 + > android/tester-main.c | 1 + > client/mgmt.c | 1 + > emulator/serial.c | 1 + > emulator/vhci.c | 1 + > monitor/att.c | 2 +- > peripheral/efivars.c | 1 + > profiles/audio/a2dp.c | 1 + > src/adapter.c | 1 + > src/device.c | 1 + > src/gatt-database.c | 1 + > src/main.c | 1 + > src/rfkill.c | 1 + > src/storage.c | 1 + > src/textfile.c | 1 + > tools/bluemoon.c | 1 + > tools/hciattach.c | 1 + > tools/hciattach_ath3k.c | 1 + > tools/hciattach_intel.c | 1 + > tools/hciattach_st.c | 1 + > tools/hciattach_ti.c | 1 + > tools/test-runner.c | 1 + > 23 files changed, 23 insertions(+), 1 deletion(-) Here is the summary with links: - Fix missing inclusion of <limits.h> https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=cd1c6b666fa9 You are awesome, thank you!
diff --git a/android/ipc-tester.c b/android/ipc-tester.c index 780e1dc4ce1c..68e2ad10e747 100644 --- a/android/ipc-tester.c +++ b/android/ipc-tester.c @@ -17,6 +17,7 @@ #include <unistd.h> #include <errno.h> #include <poll.h> +#include <limits.h> #include <sys/socket.h> #include <sys/types.h> diff --git a/android/system-emulator.c b/android/system-emulator.c index bf1499df0957..50bb088d3188 100644 --- a/android/system-emulator.c +++ b/android/system-emulator.c @@ -19,6 +19,7 @@ #include <stdlib.h> #include <signal.h> #include <string.h> +#include <limits.h> #include <libgen.h> #include <poll.h> #include <sys/wait.h> diff --git a/android/tester-main.c b/android/tester-main.c index 317c1de06463..361c519ef5a3 100644 --- a/android/tester-main.c +++ b/android/tester-main.c @@ -7,6 +7,7 @@ #define _GNU_SOURCE #include <stdbool.h> #include <unistd.h> +#include <limits.h> #include <libgen.h> #include <sys/un.h> diff --git a/client/mgmt.c b/client/mgmt.c index 44bf4d2019ea..fba409f823ef 100644 --- a/client/mgmt.c +++ b/client/mgmt.c @@ -17,6 +17,7 @@ #include <unistd.h> #include <stdlib.h> #include <string.h> +#include <limits.h> #include <sys/types.h> #include <sys/param.h> #include <sys/socket.h> diff --git a/emulator/serial.c b/emulator/serial.c index c9e6d7cd67c8..b74556b13547 100644 --- a/emulator/serial.c +++ b/emulator/serial.c @@ -21,6 +21,7 @@ #include <stdlib.h> #include <string.h> #include <fcntl.h> +#include <limits.h> #include <sys/param.h> #include <sys/epoll.h> #include <sys/uio.h> diff --git a/emulator/vhci.c b/emulator/vhci.c index 355ab63897dc..cab35354549e 100644 --- a/emulator/vhci.c +++ b/emulator/vhci.c @@ -23,6 +23,7 @@ #include <fcntl.h> #include <unistd.h> #include <dirent.h> +#include <limits.h> #include "lib/bluetooth.h" #include "lib/hci.h" diff --git a/monitor/att.c b/monitor/att.c index 73a61658454f..3f41c2bd096f 100644 --- a/monitor/att.c +++ b/monitor/att.c @@ -22,7 +22,7 @@ #include <inttypes.h> #include <stdbool.h> #include <errno.h> -#include <linux/limits.h> +#include <limits.h> #include <sys/stat.h> #include <glib.h> diff --git a/peripheral/efivars.c b/peripheral/efivars.c index 987572b63968..d4e724e2ded6 100644 --- a/peripheral/efivars.c +++ b/peripheral/efivars.c @@ -20,6 +20,7 @@ #include <string.h> #include <stdlib.h> #include <stdint.h> +#include <limits.h> #include <sys/stat.h> #include <sys/types.h> #include <sys/param.h> diff --git a/profiles/audio/a2dp.c b/profiles/audio/a2dp.c index a6489a76311d..d6c97e7bfde1 100644 --- a/profiles/audio/a2dp.c +++ b/profiles/audio/a2dp.c @@ -19,6 +19,7 @@ #include <stdlib.h> #include <stdio.h> #include <errno.h> +#include <limits.h> #include <dbus/dbus.h> #include <glib.h> diff --git a/src/adapter.c b/src/adapter.c index d6c05819627a..916cf8b6bd11 100644 --- a/src/adapter.c +++ b/src/adapter.c @@ -24,6 +24,7 @@ #include <sys/file.h> #include <sys/stat.h> #include <dirent.h> +#include <limits.h> #include <glib.h> #include <dbus/dbus.h> diff --git a/src/device.c b/src/device.c index 0f18c8c7f54e..20566c918fa5 100644 --- a/src/device.c +++ b/src/device.c @@ -22,6 +22,7 @@ #include <errno.h> #include <dirent.h> #include <time.h> +#include <limits.h> #include <sys/stat.h> #include <glib.h> diff --git a/src/gatt-database.c b/src/gatt-database.c index 6c84b085ca29..a86e528fd0e2 100644 --- a/src/gatt-database.c +++ b/src/gatt-database.c @@ -16,6 +16,7 @@ #include <stdlib.h> #include <errno.h> #include <unistd.h> +#include <limits.h> #include "lib/bluetooth.h" #include "lib/sdp.h" diff --git a/src/main.c b/src/main.c index 62453bffaf57..69ae1b1e374d 100644 --- a/src/main.c +++ b/src/main.c @@ -22,6 +22,7 @@ #include <string.h> #include <signal.h> #include <stdbool.h> +#include <limits.h> #include <sys/signalfd.h> #include <sys/types.h> #include <sys/stat.h> diff --git a/src/rfkill.c b/src/rfkill.c index 8a0e48f01c4f..88cad1c9e19d 100644 --- a/src/rfkill.c +++ b/src/rfkill.c @@ -20,6 +20,7 @@ #include <stdint.h> #include <stdlib.h> #include <string.h> +#include <limits.h> #include <glib.h> diff --git a/src/storage.c b/src/storage.c index 6e69be978b46..187ba156ce6c 100644 --- a/src/storage.c +++ b/src/storage.c @@ -21,6 +21,7 @@ #include <unistd.h> #include <stdlib.h> #include <time.h> +#include <limits.h> #include <sys/file.h> #include <sys/stat.h> diff --git a/src/textfile.c b/src/textfile.c index a5b9e73a6421..313098f38c6e 100644 --- a/src/textfile.c +++ b/src/textfile.c @@ -21,6 +21,7 @@ #include <stdlib.h> #include <stdarg.h> #include <string.h> +#include <limits.h> #include <sys/file.h> #include <sys/stat.h> #include <sys/mman.h> diff --git a/tools/bluemoon.c b/tools/bluemoon.c index f50107a2a7e3..9aaf6428da42 100644 --- a/tools/bluemoon.c +++ b/tools/bluemoon.c @@ -18,6 +18,7 @@ #include <unistd.h> #include <stdlib.h> #include <string.h> +#include <limits.h> #include <getopt.h> #include <sys/stat.h> #include <sys/param.h> diff --git a/tools/hciattach.c b/tools/hciattach.c index 276a4e56ef9d..adf79baf6ebd 100644 --- a/tools/hciattach.c +++ b/tools/hciattach.c @@ -26,6 +26,7 @@ #include <termios.h> #include <time.h> #include <poll.h> +#include <limits.h> #include <sys/time.h> #include <sys/param.h> #include <sys/ioctl.h> diff --git a/tools/hciattach_ath3k.c b/tools/hciattach_ath3k.c index d119155bb53b..8922b480f629 100644 --- a/tools/hciattach_ath3k.c +++ b/tools/hciattach_ath3k.c @@ -16,6 +16,7 @@ #include <string.h> #include <ctype.h> #include <time.h> +#include <limits.h> #include <sys/stat.h> #include <sys/time.h> #include <sys/types.h> diff --git a/tools/hciattach_intel.c b/tools/hciattach_intel.c index e243b3d07c5e..b68678991bf9 100644 --- a/tools/hciattach_intel.c +++ b/tools/hciattach_intel.c @@ -19,6 +19,7 @@ #include <string.h> #include <errno.h> #include <fcntl.h> +#include <limits.h> #include <sys/param.h> #include <sys/ioctl.h> #include <time.h> diff --git a/tools/hciattach_st.c b/tools/hciattach_st.c index 4a7186aa6633..def761305944 100644 --- a/tools/hciattach_st.c +++ b/tools/hciattach_st.c @@ -12,6 +12,7 @@ #include <config.h> #endif +#include <limits.h> #include <stdio.h> #include <errno.h> #include <fcntl.h> diff --git a/tools/hciattach_ti.c b/tools/hciattach_ti.c index 24efceaa1ae5..c0a0025ff888 100644 --- a/tools/hciattach_ti.c +++ b/tools/hciattach_ti.c @@ -14,6 +14,7 @@ #endif #define _GNU_SOURCE +#include <limits.h> #include <stdio.h> #include <errno.h> #include <unistd.h> diff --git a/tools/test-runner.c b/tools/test-runner.c index de0f2260480c..f0dbb4c481bb 100644 --- a/tools/test-runner.c +++ b/tools/test-runner.c @@ -23,6 +23,7 @@ #include <string.h> #include <getopt.h> #include <poll.h> +#include <limits.h> #include <sys/wait.h> #include <sys/stat.h> #include <sys/types.h>
Needed for PATH_MAX. Signed-off-by: Ismael Luceno <ismael@iodev.co.uk> --- android/ipc-tester.c | 1 + android/system-emulator.c | 1 + android/tester-main.c | 1 + client/mgmt.c | 1 + emulator/serial.c | 1 + emulator/vhci.c | 1 + monitor/att.c | 2 +- peripheral/efivars.c | 1 + profiles/audio/a2dp.c | 1 + src/adapter.c | 1 + src/device.c | 1 + src/gatt-database.c | 1 + src/main.c | 1 + src/rfkill.c | 1 + src/storage.c | 1 + src/textfile.c | 1 + tools/bluemoon.c | 1 + tools/hciattach.c | 1 + tools/hciattach_ath3k.c | 1 + tools/hciattach_intel.c | 1 + tools/hciattach_st.c | 1 + tools/hciattach_ti.c | 1 + tools/test-runner.c | 1 + 23 files changed, 23 insertions(+), 1 deletion(-)