| Message ID | 20241015232212.19242-1-everestkc@everestkc.com.np (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8f66f649846348871148413dcb6af69d9adf760a |
| Headers | show |
| Series | [V4,next] Bluetooth: btintel_pcie: Remove structrually deadcode | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | fail | WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search 15: B3 Line contains hard tab characters (\t): " - Removed the link to Coverity Scan report" 19: B2 Line has trailing whitespace: " " |
| tedd_an/SubjectPrefix | success | Gitlint PASS |
| tedd_an/BuildKernel | success | BuildKernel PASS |
| tedd_an/CheckAllWarning | success | CheckAllWarning PASS |
| tedd_an/CheckSparse | success | CheckSparse PASS |
On Tue, Oct 15, 2024 at 05:22:05PM -0600, Everest K.C. wrote: > The switch case statement has a default branch. Thus, the return > statement at the end of the function can never be reached. > Fix it by removing the return statement at the end of the > function. > > This issue was reported by Coverity Scan. > > Fixes: 5ea625845b0f ("Bluetooth: btintel_pcie: Add handshake between driver and firmware") > Signed-off-by: Everest K.C. <everestkc@everestkc.com.np> > Reviewed-by: Shuah Khan <skhan@linuxfoundation.org> > --- > V3 -> V4: - Fixed typo in the subject I don't like to be the typo police but, no, you didn't fix the typo. :P regards, dan carpenter
On Wed, Oct 16, 2024 at 8:42 AM Dan Carpenter <dan.carpenter@linaro.org> wrote: > > On Tue, Oct 15, 2024 at 05:22:05PM -0600, Everest K.C. wrote: > > The switch case statement has a default branch. Thus, the return > > statement at the end of the function can never be reached. > > Fix it by removing the return statement at the end of the > > function. > > > > This issue was reported by Coverity Scan. > > > > Fixes: 5ea625845b0f ("Bluetooth: btintel_pcie: Add handshake between driver and firmware") > > Signed-off-by: Everest K.C. <everestkc@everestkc.com.np> > > Reviewed-by: Shuah Khan <skhan@linuxfoundation.org> > > --- > > V3 -> V4: - Fixed typo in the subject > > I don't like to be the typo police but, no, you didn't fix the typo. :P No, using the correct spelling helps in searching the patches in lore. Thank you, will send a V5. > regards, > dan carpenter > Thanks, Everest K.C.
Hello: This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Tue, 15 Oct 2024 17:22:05 -0600 you wrote: > The switch case statement has a default branch. Thus, the return > statement at the end of the function can never be reached. > Fix it by removing the return statement at the end of the > function. > > This issue was reported by Coverity Scan. > > [...] Here is the summary with links: - [V4,next] Bluetooth: btintel_pcie: Remove structrually deadcode https://git.kernel.org/bluetooth/bluetooth-next/c/8f66f6498463 You are awesome, thank you!
diff --git a/drivers/bluetooth/btintel_pcie.c b/drivers/bluetooth/btintel_pcie.c index e4ae8c898dfd..660496e55276 100644 --- a/drivers/bluetooth/btintel_pcie.c +++ b/drivers/bluetooth/btintel_pcie.c @@ -391,7 +391,6 @@ static inline char *btintel_pcie_alivectxt_state2str(u32 alive_intr_ctxt) default: return "unknown"; } - return "null"; } /* This function handles the MSI-X interrupt for gp0 cause (bit 0 in
The switch case statement has a default branch. Thus, the return statement at the end of the function can never be reached. Fix it by removing the return statement at the end of the function. This issue was reported by Coverity Scan. Fixes: 5ea625845b0f ("Bluetooth: btintel_pcie: Add handshake between driver and firmware") Signed-off-by: Everest K.C. <everestkc@everestkc.com.np> Reviewed-by: Shuah Khan <skhan@linuxfoundation.org> --- V3 -> V4: - Fixed typo in the subject V2 -> V3: - Removed that the change was successfully built - Removed the link to Coverity Scan report V1 -> V2: - Changed "Fixing" to "Fix" in the changelog - Added that the change was successfully built - Added kernel-janitors mailing list to CC drivers/bluetooth/btintel_pcie.c | 1 - 1 file changed, 1 deletion(-)