From patchwork Tue Oct 15 23:22:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Everest K.C." X-Patchwork-Id: 13837419 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6FD21D2B34 for ; Tue, 15 Oct 2024 23:23:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729034611; cv=none; b=c7CPCu5+j/EGssDiCLB5wAvbtDd8A22eWKpgXASYabZPrLLrCe13UMvHIqhFLqeL/nnIaH7GA7w0V3cF6Aqrdn0xFaSJLXBAQ1eMv1+VtQj+DwhRu6UF0DH2GFOC/XNr/YNyALDIWbHUCq9JmSYA0P3jshW+uTksfx04EU3NIAw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729034611; c=relaxed/simple; bh=MxdmhjCxj6LiiZVUxifESDviq01IPYVB95t3KqW5Mt8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=hDrHmHzZGepsMgydn3Tshf4BeVptLRRoHM8SD058hUlHnrD3dUl4cUsZHor+h966IbYjEYL8m1+E0/l/VrJI1sDW/1kv0RRmv7XAWmA8J9nnxaPlyN4BQySr9sI8AP0MnJJECUoqtCzY5lk/Ryfb2HZVQi6Zc4QYVhKyVVovmU8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=everestkc.com.np; spf=pass smtp.mailfrom=everestkc.com.np; dkim=pass (2048-bit key) header.d=everestkc-com-np.20230601.gappssmtp.com header.i=@everestkc-com-np.20230601.gappssmtp.com header.b=HOb511sW; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=everestkc.com.np Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=everestkc.com.np Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=everestkc-com-np.20230601.gappssmtp.com header.i=@everestkc-com-np.20230601.gappssmtp.com header.b="HOb511sW" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-20cb89a4e4cso27651725ad.3 for ; Tue, 15 Oct 2024 16:23:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=everestkc-com-np.20230601.gappssmtp.com; s=20230601; t=1729034609; x=1729639409; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=fDDXRG1a8a8p6wsQpSeuY48H+wQjbIigs/w/koYWqjQ=; b=HOb511sWNUWm7CZRto3Jl9TULdy3sO2C4Um732xL7Egn9uFcOAJQwA2uQgSAsOXRbx SOr/LFFhWvGKDBy4w95I9Gw9+aYSLEIqmgNBgCpKtMlLMeqvqG/7elVczv3/hYO+rW54 76HOZYle0Xkyp0RnwMpr24U1nNMMF6thDsxMakzPAjC5Xf50u/Yn6AY51MiP/ChM8hui tkQAp2i435NtBowYhQmQ21lakUzcZAJR3P+6Efg052/BBJUvGEI/y9V4x/3KyAYnuAHA LQXO2IekgtjXx3YGXQcfjWuolObUzv+rH3IkYCBVa0kcgQ1R3UGNMkyYfNp4h08HMbRE 9Vjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729034609; x=1729639409; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fDDXRG1a8a8p6wsQpSeuY48H+wQjbIigs/w/koYWqjQ=; b=LujGy8FUUCR30yqP9tNgIPVoFXYUxDtcowm96nU4Aq8F77SGUYNANl+H1GguUqak1k +zjpAa6hZfj+UGkUxK+j4hA6eIGhRDT2+o02WEpsRiSNvcTDOiutNnzdJIKuVwusnl6S NSOyn2pKXgP9prRJk3aFXgYAFQvV1HVdeKusHd7CsCZu6mWSKTNvfpaJ2dYxuriSFT8z W064mDlgHPdES7b4DRU9Lm8K1sOmBmE5czVLJPDFX9Mi50C9ukAEEz4xvleCW56CzbLC SHvLMbNQhoAEEyML5bbwepgx71hhajv4aqLGcLCIjaQgscR3G7EShQlIuUtoWr7l/WvE x6LQ== X-Forwarded-Encrypted: i=1; AJvYcCVu1qV7iRvjsuctdk1mkMo8IplgPErNxmT7Zpu8l8fY5YQaxiVnGshZNNTrbq1DCcaOTL7GUV1i7WUpsIjfGXE=@vger.kernel.org X-Gm-Message-State: AOJu0YxUz1kZ2+TyPPPOkjL/O3i2s7Fr/DPgcrwVQRP1an9jiB74uz8o QxqQJqXlKwvKSAMD05yMBQaBAEh1hjE286OUDwIcSiE3n8M1eEGmyStGlYgzc5w= X-Google-Smtp-Source: AGHT+IHQxjs3tD7xHQ8tLAnTy4Z6hQCKOP3SL8p5ic3MCYz2+5uKvajxBaK8fp9urUvp8985lajYtQ== X-Received: by 2002:a17:902:f54e:b0:20c:98f8:e0fa with SMTP id d9443c01a7336-20d27e4669emr29774405ad.11.1729034609025; Tue, 15 Oct 2024 16:23:29 -0700 (PDT) Received: from localhost.localdomain ([81.17.122.160]) by smtp.googlemail.com with ESMTPSA id 41be03b00d2f7-7ea9c6c1948sm2022927a12.27.2024.10.15.16.23.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Oct 2024 16:23:28 -0700 (PDT) From: "Everest K.C." To: marcel@holtmann.org, luiz.dentz@gmail.com Cc: "Everest K.C." , skhan@linuxfoundation.org, dan.carpenter@linaro.org, kernel-janitors@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH V4][next] Bluetooth: btintel_pcie: Remove structrually deadcode Date: Tue, 15 Oct 2024 17:22:05 -0600 Message-ID: <20241015232212.19242-1-everestkc@everestkc.com.np> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The switch case statement has a default branch. Thus, the return statement at the end of the function can never be reached. Fix it by removing the return statement at the end of the function. This issue was reported by Coverity Scan. Fixes: 5ea625845b0f ("Bluetooth: btintel_pcie: Add handshake between driver and firmware") Signed-off-by: Everest K.C. Reviewed-by: Shuah Khan --- V3 -> V4: - Fixed typo in the subject V2 -> V3: - Removed that the change was successfully built - Removed the link to Coverity Scan report V1 -> V2: - Changed "Fixing" to "Fix" in the changelog - Added that the change was successfully built - Added kernel-janitors mailing list to CC drivers/bluetooth/btintel_pcie.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/bluetooth/btintel_pcie.c b/drivers/bluetooth/btintel_pcie.c index e4ae8c898dfd..660496e55276 100644 --- a/drivers/bluetooth/btintel_pcie.c +++ b/drivers/bluetooth/btintel_pcie.c @@ -391,7 +391,6 @@ static inline char *btintel_pcie_alivectxt_state2str(u32 alive_intr_ctxt) default: return "unknown"; } - return "null"; } /* This function handles the MSI-X interrupt for gp0 cause (bit 0 in