diff mbox series

[BlueZ,v1] avrcp: Fix not marking AVRCP_EVENT_VOLUME_CHANGED as supported

Message ID 20241108181921.309039-1-luiz.dentz@gmail.com (mailing list archive)
State Accepted
Commit de1b3a5ac3991f5cfb9278c2887c0be2b71dc58b
Headers show
Series [BlueZ,v1] avrcp: Fix not marking AVRCP_EVENT_VOLUME_CHANGED as supported | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/CheckPatch success CheckPatch PASS
tedd_an/GitLint success Gitlint PASS
tedd_an/BuildEll success Build ELL PASS
tedd_an/BluezMake success Bluez Make PASS
tedd_an/MakeCheck success Bluez Make Check PASS
tedd_an/MakeDistcheck success Make Distcheck PASS
tedd_an/CheckValgrind success Check Valgrind PASS
tedd_an/CheckSmatch success CheckSparse PASS
tedd_an/bluezmakeextell success Make External ELL PASS
tedd_an/IncrementalBuild success Incremental Build PASS
tedd_an/ScanBuild success Scan Build PASS

Commit Message

Luiz Augusto von Dentz Nov. 8, 2024, 6:19 p.m. UTC
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

If avrcp_volume_supported return true then AVRCP_EVENT_VOLUME_CHANGED
shall be marked as supported.

Fixes: https://github.com/bluez/bluez/issues/1007
---
 profiles/audio/avrcp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

bluez.test.bot@gmail.com Nov. 8, 2024, 8:11 p.m. UTC | #1
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=907911

---Test result---

Test Summary:
CheckPatch                    PASS      0.25 seconds
GitLint                       PASS      0.19 seconds
BuildEll                      PASS      24.63 seconds
BluezMake                     PASS      1750.10 seconds
MakeCheck                     PASS      12.97 seconds
MakeDistcheck                 PASS      180.21 seconds
CheckValgrind                 PASS      254.75 seconds
CheckSmatch                   PASS      358.79 seconds
bluezmakeextell               PASS      120.89 seconds
IncrementalBuild              PASS      1501.67 seconds
ScanBuild                     PASS      1024.91 seconds



---
Regards,
Linux Bluetooth
patchwork-bot+bluetooth@kernel.org Nov. 8, 2024, 8:20 p.m. UTC | #2
Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Fri,  8 Nov 2024 13:19:21 -0500 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> If avrcp_volume_supported return true then AVRCP_EVENT_VOLUME_CHANGED
> shall be marked as supported.
> 
> Fixes: https://github.com/bluez/bluez/issues/1007
> 
> [...]

Here is the summary with links:
  - [BlueZ,v1] avrcp: Fix not marking AVRCP_EVENT_VOLUME_CHANGED as supported
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=de1b3a5ac399

You are awesome, thank you!
diff mbox series

Patch

diff --git a/profiles/audio/avrcp.c b/profiles/audio/avrcp.c
index b5e6548e6600..9fe8f55e5dbf 100644
--- a/profiles/audio/avrcp.c
+++ b/profiles/audio/avrcp.c
@@ -4268,7 +4268,7 @@  static void target_init(struct avrcp *session)
 	if (target->version < 0x0104)
 		return;
 
-	if (!avrcp_volume_supported(target))
+	if (avrcp_volume_supported(target))
 		session->supported_events |=
 				(1 << AVRCP_EVENT_VOLUME_CHANGED);