| Message ID | 20241119163731.2767660-1-luiz.dentz@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5c65356cae64ddbc95210deb36ee66430645edf8 |
| Headers | show |
| Series | [BlueZ,v1] shared/att: Fix failing to set security level | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | success | CheckSparse PASS |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/ScanBuild | success | Scan Build PASS |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=911015 ---Test result--- Test Summary: CheckPatch PENDING 0.25 seconds GitLint PENDING 0.23 seconds BuildEll PASS 21.09 seconds BluezMake PASS 1713.45 seconds MakeCheck PASS 13.66 seconds MakeDistcheck PASS 164.68 seconds CheckValgrind PASS 219.81 seconds CheckSmatch PASS 279.14 seconds bluezmakeextell PASS 101.44 seconds IncrementalBuild PENDING 0.26 seconds ScanBuild PASS 878.10 seconds Details ############################## Test: CheckPatch - PENDING Desc: Run checkpatch.pl script Output: ############################## Test: GitLint - PENDING Desc: Run gitlint Output: ############################## Test: IncrementalBuild - PENDING Desc: Incremental build with the patches in the series Output: --- Regards, Linux Bluetooth
Hello: This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Tue, 19 Nov 2024 11:37:31 -0500 you wrote: > From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> > > bt_att_chan_set_security attempts to set BT_SECURITY without first > checking what is the current security level which may cause errors > since the kernel does actually return -EINVAL when the security doesn't > change. > > [...] Here is the summary with links: - [BlueZ,v1] shared/att: Fix failing to set security level https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=5c65356cae64 You are awesome, thank you!
diff --git a/src/shared/att.c b/src/shared/att.c index 4a406f4b91a4..dabbdb4315eb 100644 --- a/src/shared/att.c +++ b/src/shared/att.c @@ -727,6 +727,9 @@ static bool bt_att_chan_set_security(struct bt_att_chan *chan, int level) { struct bt_security sec; + if (level == bt_att_chan_get_security(chan)) + return true; + if (chan->type == BT_ATT_LOCAL) { chan->sec_level = level; return true;
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> bt_att_chan_set_security attempts to set BT_SECURITY without first checking what is the current security level which may cause errors since the kernel does actually return -EINVAL when the security doesn't change. --- src/shared/att.c | 3 +++ 1 file changed, 3 insertions(+)