diff mbox series

[v4,4/4] power: sequencing: qcom-wcn: add support for the WCN6750 PMU

Message ID 20241204131706.20791-5-quic_janathot@quicinc.com (mailing list archive)
State Superseded
Headers show
Series Enable Bluetooth on qcs6490-rb3gen2 board | expand

Checks

Context Check Description
tedd_an/pre-ci_am fail error: patch failed: drivers/power/sequencing/pwrseq-qcom-wcn.c:293 error: drivers/power/sequencing/pwrseq-qcom-wcn.c: patch does not apply hint: Use 'git am --show-current-patch' to see the failed patch

Commit Message

Janaki Ramaiah Thota Dec. 4, 2024, 1:17 p.m. UTC
Enable support for controlling the power-up sequence of the PMU inside
the WCN6750 model.

Signed-off-by: Janaki Ramaiah Thota <quic_janathot@quicinc.com>
---
 drivers/power/sequencing/pwrseq-qcom-wcn.c | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

Comments

Krzysztof Kozlowski Dec. 5, 2024, 8:08 a.m. UTC | #1
On Wed, Dec 04, 2024 at 06:47:06PM +0530, Janaki Ramaiah Thota wrote:
> Enable support for controlling the power-up sequence of the PMU inside
> the WCN6750 model.
> 
> Signed-off-by: Janaki Ramaiah Thota <quic_janathot@quicinc.com>
> ---
>  drivers/power/sequencing/pwrseq-qcom-wcn.c | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/drivers/power/sequencing/pwrseq-qcom-wcn.c b/drivers/power/sequencing/pwrseq-qcom-wcn.c
> index 682a9beac69e..e38da79f0ada 100644
> --- a/drivers/power/sequencing/pwrseq-qcom-wcn.c
> +++ b/drivers/power/sequencing/pwrseq-qcom-wcn.c
> @@ -293,6 +293,24 @@ static const struct pwrseq_qcom_wcn_pdata pwrseq_wcn6855_of_data = {
>  	.targets = pwrseq_qcom_wcn6855_targets,
>  };
>  
> +static const char *const pwrseq_wcn6750_vregs[] = {
> +	"vddaon",
> +	"vddasd",
> +	"vddpmu",
> +	"vddrfa0p8",
> +	"vddrfa1p2",
> +	"vddrfa1p7",
> +	"vddrfa2p2",
> +};
> +
> +static const struct pwrseq_qcom_wcn_pdata pwrseq_wcn6750_of_data = {
> +	.vregs = pwrseq_wcn6750_vregs,
> +	.num_vregs = ARRAY_SIZE(pwrseq_wcn6750_vregs),
> +	.pwup_delay_ms = 50,
> +	.gpio_enable_delay_ms = 5,
> +	.targets = pwrseq_qcom_wcn_targets,
> +};
> +
>  static const char *const pwrseq_wcn7850_vregs[] = {
>  	"vdd",
>  	"vddio",
> @@ -431,6 +449,10 @@ static const struct of_device_id pwrseq_qcom_wcn_of_match[] = {
>  		.compatible = "qcom,wcn7850-pmu",
>  		.data = &pwrseq_wcn7850_of_data,
>  	},
> +	{
> +		.compatible = "qcom,wcn6750-pmu",

Don't stuff things at the end of lists. Keep proper order instead.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/drivers/power/sequencing/pwrseq-qcom-wcn.c b/drivers/power/sequencing/pwrseq-qcom-wcn.c
index 682a9beac69e..e38da79f0ada 100644
--- a/drivers/power/sequencing/pwrseq-qcom-wcn.c
+++ b/drivers/power/sequencing/pwrseq-qcom-wcn.c
@@ -293,6 +293,24 @@  static const struct pwrseq_qcom_wcn_pdata pwrseq_wcn6855_of_data = {
 	.targets = pwrseq_qcom_wcn6855_targets,
 };
 
+static const char *const pwrseq_wcn6750_vregs[] = {
+	"vddaon",
+	"vddasd",
+	"vddpmu",
+	"vddrfa0p8",
+	"vddrfa1p2",
+	"vddrfa1p7",
+	"vddrfa2p2",
+};
+
+static const struct pwrseq_qcom_wcn_pdata pwrseq_wcn6750_of_data = {
+	.vregs = pwrseq_wcn6750_vregs,
+	.num_vregs = ARRAY_SIZE(pwrseq_wcn6750_vregs),
+	.pwup_delay_ms = 50,
+	.gpio_enable_delay_ms = 5,
+	.targets = pwrseq_qcom_wcn_targets,
+};
+
 static const char *const pwrseq_wcn7850_vregs[] = {
 	"vdd",
 	"vddio",
@@ -431,6 +449,10 @@  static const struct of_device_id pwrseq_qcom_wcn_of_match[] = {
 		.compatible = "qcom,wcn7850-pmu",
 		.data = &pwrseq_wcn7850_of_data,
 	},
+	{
+		.compatible = "qcom,wcn6750-pmu",
+		.data = &pwrseq_wcn6750_of_data,
+	},
 	{ }
 };
 MODULE_DEVICE_TABLE(of, pwrseq_qcom_wcn_of_match);