| Message ID | 20241209154043.105358-1-fiona.klute@gmx.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b1fd409960001a77cda2a09ecc00147ebd9c3667 |
| Headers | show |
| Series | [BlueZ,v2] Leave config files writable for owner | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | success | CheckSparse PASS |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/ScanBuild | success | Scan Build PASS |
On Mon, 2024-12-09 at 16:40 +0100, Fiona Klute wrote: > This is needed for builds running as non-root users, so the build > process and any distribution tools can create/move/delete files in > the > config directory without adjusting permissions separately. Limiting > writes from the running service needs to be done in the systemd unit > (already the case) or init script. > > See also: > https://lore.kernel.org/linux-bluetooth/4d1206df-598b-4a68-8655-74981b62ecca@gmx.de/T/ > --- > Changes v1 -> v2: > * Explicitly mention in commit message that write permission is > needed > for build as non-root user. > > Makefile.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile.am b/Makefile.am > index 297d0774c..29018a91c 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -32,7 +32,7 @@ confdir = $(sysconfdir)/bluetooth > statedir = $(localstatedir)/lib/bluetooth > > bluetoothd-fix-permissions: > - install -dm555 $(DESTDIR)$(confdir) > + install -dm755 $(DESTDIR)$(confdir) > install -dm700 $(DESTDIR)$(statedir) Reviewed-by: Bastien Nocera <hadess@hadess.net>
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=916026 ---Test result--- Test Summary: CheckPatch PENDING 0.33 seconds GitLint PENDING 0.28 seconds BuildEll PASS 20.60 seconds BluezMake PASS 1567.34 seconds MakeCheck PASS 13.16 seconds MakeDistcheck PASS 157.37 seconds CheckValgrind PASS 211.81 seconds CheckSmatch PASS 270.84 seconds bluezmakeextell PASS 98.32 seconds IncrementalBuild PENDING 0.32 seconds ScanBuild PASS 844.36 seconds Details ############################## Test: CheckPatch - PENDING Desc: Run checkpatch.pl script Output: ############################## Test: GitLint - PENDING Desc: Run gitlint Output: ############################## Test: IncrementalBuild - PENDING Desc: Incremental build with the patches in the series Output: --- Regards, Linux Bluetooth
Hello: This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Mon, 9 Dec 2024 16:40:43 +0100 you wrote: > This is needed for builds running as non-root users, so the build > process and any distribution tools can create/move/delete files in the > config directory without adjusting permissions separately. Limiting > writes from the running service needs to be done in the systemd unit > (already the case) or init script. > > See also: https://lore.kernel.org/linux-bluetooth/4d1206df-598b-4a68-8655-74981b62ecca@gmx.de/T/ > > [...] Here is the summary with links: - [BlueZ,v2] Leave config files writable for owner https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=b1fd40996000 You are awesome, thank you!
diff --git a/Makefile.am b/Makefile.am index 297d0774c..29018a91c 100644 --- a/Makefile.am +++ b/Makefile.am @@ -32,7 +32,7 @@ confdir = $(sysconfdir)/bluetooth statedir = $(localstatedir)/lib/bluetooth bluetoothd-fix-permissions: - install -dm555 $(DESTDIR)$(confdir) + install -dm755 $(DESTDIR)$(confdir) install -dm700 $(DESTDIR)$(statedir) if DATAFILES