diff mbox series

[BlueZ] lib: Add constant for 16 bits transparent voice setting

Message ID 20241212161445.298083-1-frederic.danis@collabora.com (mailing list archive)
State Accepted
Commit 9b631e09e943d6a3b248f0210e4f785a1cc48c25
Headers show
Series [BlueZ] lib: Add constant for 16 bits transparent voice setting | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/BuildEll success Build ELL PASS
tedd_an/BluezMake success Bluez Make PASS
tedd_an/MakeCheck success Bluez Make Check PASS
tedd_an/MakeDistcheck success Make Distcheck PASS
tedd_an/CheckValgrind success Check Valgrind PASS
tedd_an/CheckSmatch success CheckSparse PASS
tedd_an/bluezmakeextell success Make External ELL PASS
tedd_an/ScanBuild success Scan Build PASS

Commit Message

Frédéric Danis Dec. 12, 2024, 4:14 p.m. UTC 
Add 16 bits, 2s complement, transparent air coding format for mSBC.
Corresponding commit implements functionality on kernel side.

The voice setting is used by sco_connect() or sco_conn_defer_accept()
after being set by sco_sock_setsockopt().

The PCM part of the voice setting is used for offload mode through PCM
chipset port.
This commits add support for mSBC 16 bits offloading, i.e. audio data
not transported over HCI.

The BCM4349B1 supports 16 bits transparent data on its I2S port.
If BT_VOICE_TRANSPARENT is used when accepting a SCO connection, this
gives only garbage audio while using BT_VOICE_TRANSPARENT_16BIT gives
correct audio.
This has been tested with connection to iPhone 14 and Samsung S24.
---
 lib/bluetooth.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Luiz Augusto von Dentz Dec. 12, 2024, 4:46 p.m. UTC | #1 
Hi Frédéric,

On Thu, Dec 12, 2024 at 11:38 AM Frédéric Danis
<frederic.danis@collabora.com> wrote:
>
> Add 16 bits, 2s complement, transparent air coding format for mSBC.
> Corresponding commit implements functionality on kernel side.
>
> The voice setting is used by sco_connect() or sco_conn_defer_accept()
> after being set by sco_sock_setsockopt().
>
> The PCM part of the voice setting is used for offload mode through PCM
> chipset port.
> This commits add support for mSBC 16 bits offloading, i.e. audio data
> not transported over HCI.
>
> The BCM4349B1 supports 16 bits transparent data on its I2S port.
> If BT_VOICE_TRANSPARENT is used when accepting a SCO connection, this
> gives only garbage audio while using BT_VOICE_TRANSPARENT_16BIT gives
> correct audio.
> This has been tested with connection to iPhone 14 and Samsung S24.
> ---
>  lib/bluetooth.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lib/bluetooth.h b/lib/bluetooth.h
> index 073ed875d..32e58678b 100644
> --- a/lib/bluetooth.h
> +++ b/lib/bluetooth.h
> @@ -111,6 +111,7 @@ struct bt_voice {
>
>  #define BT_VOICE_TRANSPARENT                   0x0003
>  #define BT_VOICE_CVSD_16BIT                    0x0060
> +#define BT_VOICE_TRANSPARENT_16BIT             0x0063
>
>  #define BT_PHY                 14

Are you planning on adding support for sco-tester as well?

> --
> 2.34.1
>
>
bluez.test.bot@gmail.com Dec. 12, 2024, 5:15 p.m. UTC | #2 
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=917289

---Test result---

Test Summary:
CheckPatch                    PENDING   0.35 seconds
GitLint                       PENDING   0.29 seconds
BuildEll                      PASS      20.44 seconds
BluezMake                     PASS      1517.29 seconds
MakeCheck                     PASS      13.29 seconds
MakeDistcheck                 PASS      158.94 seconds
CheckValgrind                 PASS      214.78 seconds
CheckSmatch                   PASS      272.15 seconds
bluezmakeextell               PASS      98.84 seconds
IncrementalBuild              PENDING   0.33 seconds
ScanBuild                     PASS      851.99 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth
patchwork-bot+bluetooth@kernel.org Dec. 16, 2024, 9:50 p.m. UTC | #3 
Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Thu, 12 Dec 2024 17:14:45 +0100 you wrote:
> Add 16 bits, 2s complement, transparent air coding format for mSBC.
> Corresponding commit implements functionality on kernel side.
> 
> The voice setting is used by sco_connect() or sco_conn_defer_accept()
> after being set by sco_sock_setsockopt().
> 
> The PCM part of the voice setting is used for offload mode through PCM
> chipset port.
> This commits add support for mSBC 16 bits offloading, i.e. audio data
> not transported over HCI.
> 
> [...]

Here is the summary with links:
  - [BlueZ] lib: Add constant for 16 bits transparent voice setting
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=9b631e09e943

You are awesome, thank you!
diff mbox series

Patch

diff --git a/lib/bluetooth.h b/lib/bluetooth.h
index 073ed875d..32e58678b 100644
--- a/lib/bluetooth.h
+++ b/lib/bluetooth.h
@@ -111,6 +111,7 @@  struct bt_voice {
 
 #define BT_VOICE_TRANSPARENT			0x0003
 #define BT_VOICE_CVSD_16BIT			0x0060
+#define BT_VOICE_TRANSPARENT_16BIT		0x0063
 
 #define BT_PHY			14