| Message ID | 20241213094118.23647-1-chris.lu@mediatek.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Bluetooth: btmtk: add quirk to support HCI_QUIRK_SIMULTANEOUS_DISCOVERY | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/SubjectPrefix | success | Gitlint PASS |
| tedd_an/BuildKernel | success | BuildKernel PASS |
| tedd_an/CheckAllWarning | success | CheckAllWarning PASS |
| tedd_an/CheckSparse | success | CheckSparse PASS |
| tedd_an/BuildKernel32 | success | BuildKernel32 PASS |
| tedd_an/TestRunnerSetup | success | TestRunnerSetup PASS |
| tedd_an/TestRunner_l2cap-tester | success | TestRunner PASS |
| tedd_an/TestRunner_iso-tester | success | TestRunner PASS |
| tedd_an/TestRunner_bnep-tester | success | TestRunner PASS |
| tedd_an/TestRunner_mgmt-tester | success | TestRunner PASS |
| tedd_an/TestRunner_rfcomm-tester | success | TestRunner PASS |
| tedd_an/TestRunner_sco-tester | success | TestRunner PASS |
| tedd_an/TestRunner_ioctl-tester | success | TestRunner PASS |
| tedd_an/TestRunner_mesh-tester | success | TestRunner PASS |
| tedd_an/TestRunner_smp-tester | success | TestRunner PASS |
| tedd_an/TestRunner_userchan-tester | success | TestRunner PASS |
Dear Chris, Thank you for your patch. Am 13.12.24 um 10:41 schrieb Chris Lu: > Add quirk to support HCI_QUIRK_SIMULTANEOUS_DISCOVERY feature for MT79xx > series chipset. It’d be great if you elaborated. What is the problem. Why is a quirk needed? Is a firmware update going to fix it? > Signed-off-by: Chris Lu <chris.lu@mediatek.com> > --- > drivers/bluetooth/btmtk.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/bluetooth/btmtk.c b/drivers/bluetooth/btmtk.c > index 8a3f7c3fcfec..562d6ecf0b71 100644 > --- a/drivers/bluetooth/btmtk.c > +++ b/drivers/bluetooth/btmtk.c > @@ -1367,6 +1367,9 @@ int btmtk_usb_setup(struct hci_dev *hdev) > return err; > } > > + /* Apply common HCI quirks for MediaTek chipset */ > + set_bit(HCI_QUIRK_SIMULTANEOUS_DISCOVERY, &hdev->quirks); > + The commit message only talks about MT79xx series chipset. The comment talks about all MediaTek chipsets. > hci_set_msft_opcode(hdev, 0xFD30); > hci_set_aosp_capable(hdev); Kind regards, Paul
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=917527 ---Test result--- Test Summary: CheckPatch PENDING 0.31 seconds GitLint PENDING 0.19 seconds SubjectPrefix PASS 0.12 seconds BuildKernel PASS 24.92 seconds CheckAllWarning PASS 27.10 seconds CheckSparse PASS 30.86 seconds BuildKernel32 PASS 24.79 seconds TestRunnerSetup PASS 440.79 seconds TestRunner_l2cap-tester PASS 22.53 seconds TestRunner_iso-tester PASS 29.90 seconds TestRunner_bnep-tester PASS 4.82 seconds TestRunner_mgmt-tester PASS 120.81 seconds TestRunner_rfcomm-tester PASS 7.92 seconds TestRunner_sco-tester PASS 9.35 seconds TestRunner_ioctl-tester PASS 8.06 seconds TestRunner_mesh-tester PASS 5.94 seconds TestRunner_smp-tester PASS 6.92 seconds TestRunner_userchan-tester PASS 5.00 seconds IncrementalBuild PENDING 0.40 seconds Details ############################## Test: CheckPatch - PENDING Desc: Run checkpatch.pl script Output: ############################## Test: GitLint - PENDING Desc: Run gitlint Output: ############################## Test: IncrementalBuild - PENDING Desc: Incremental build with the patches in the series Output: --- Regards, Linux Bluetooth
Hi Paul, Thanks for your input, On Fri, 2024-12-13 at 10:46 +0100, Paul Menzel wrote: > External email : Please do not click links or open attachments until > you have verified the sender or the content. > > > Dear Chris, > > > Thank you for your patch. > > > Am 13.12.24 um 10:41 schrieb Chris Lu: > > Add quirk to support HCI_QUIRK_SIMULTANEOUS_DISCOVERY feature for > > MT79xx > > series chipset. > > It’d be great if you elaborated. What is the problem. Why is a quirk > needed? Is a firmware update going to fix it? This quirk is related to do BR/EDR inquiry and LE scan simultaneously. More detailed was described in hci.h. Due to requirement from customer and other chip vendors also enable HCI_QUIRK_SIMULTANEOUS_DISCOVERY, MediaTek upload this patch to enable the feature as well. There is no need to update firmware. > > > Signed-off-by: Chris Lu <chris.lu@mediatek.com> > > --- > > drivers/bluetooth/btmtk.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/bluetooth/btmtk.c b/drivers/bluetooth/btmtk.c > > index 8a3f7c3fcfec..562d6ecf0b71 100644 > > --- a/drivers/bluetooth/btmtk.c > > +++ b/drivers/bluetooth/btmtk.c > > @@ -1367,6 +1367,9 @@ int btmtk_usb_setup(struct hci_dev *hdev) > > return err; > > } > > > > + /* Apply common HCI quirks for MediaTek chipset */ > > + set_bit(HCI_QUIRK_SIMULTANEOUS_DISCOVERY, &hdev- > > >quirks); > > + > > The commit message only talks about MT79xx series chipset. The > comment > talks about all MediaTek chipsets. I'll modify commit message to avoid ambiguity and upload another version. Thanks a lot, Chris Lu > > > hci_set_msft_opcode(hdev, 0xFD30); > > hci_set_aosp_capable(hdev); > > > Kind regards, > > Paul
diff --git a/drivers/bluetooth/btmtk.c b/drivers/bluetooth/btmtk.c index 8a3f7c3fcfec..562d6ecf0b71 100644 --- a/drivers/bluetooth/btmtk.c +++ b/drivers/bluetooth/btmtk.c @@ -1367,6 +1367,9 @@ int btmtk_usb_setup(struct hci_dev *hdev) return err; } + /* Apply common HCI quirks for MediaTek chipset */ + set_bit(HCI_QUIRK_SIMULTANEOUS_DISCOVERY, &hdev->quirks); + hci_set_msft_opcode(hdev, 0xFD30); hci_set_aosp_capable(hdev);
Add quirk to support HCI_QUIRK_SIMULTANEOUS_DISCOVERY feature for MT79xx series chipset. Signed-off-by: Chris Lu <chris.lu@mediatek.com> --- drivers/bluetooth/btmtk.c | 3 +++ 1 file changed, 3 insertions(+)