diff mbox series

[v2] obexctl: Enable Map folderlisting operation from obexctl

Message ID 20241216152330.2579138-1-quic_amisjain@quicinc.com (mailing list archive)
State Accepted
Commit c2caa26a4d621ad9fc2def9325d7ef8fad81ebdc
Headers show
Series [v2] obexctl: Enable Map folderlisting operation from obexctl | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/BuildEll success Build ELL PASS
tedd_an/BluezMake success Bluez Make PASS
tedd_an/MakeCheck success Bluez Make Check PASS
tedd_an/MakeDistcheck success Make Distcheck PASS
tedd_an/CheckValgrind success Check Valgrind PASS
tedd_an/CheckSmatch success CheckSparse PASS
tedd_an/bluezmakeextell success Make External ELL PASS
tedd_an/ScanBuild success Scan Build PASS

Commit Message

Amisha Jain Dec. 16, 2024, 3:23 p.m. UTC 
This change is required for passing below PTS testcase -

1) MAP/MCE/MMB/BV-01-C
Verify that the MCE can retrieve a Folders Listing on the MSE.

As of now, user is able to initiate only map messagelisting
operation with command 'ls <folder_name>' and there is no way to initiate
folder listing with 'ls' command as second argument <options> is
set as compulsary.
In the obexctl code, map folderlisting gets triggered only when there is no
arguments followed by 'ls' command.
Therefore in 'ls' command, make the second argument as optional.

This change will also enable pbap vcard listing operation which also
gets triggered with 'ls' command with no args.

---
 tools/obexctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

bluez.test.bot@gmail.com Dec. 16, 2024, 4:36 p.m. UTC | #1 
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=918257

---Test result---

Test Summary:
CheckPatch                    PENDING   0.24 seconds
GitLint                       PENDING   0.23 seconds
BuildEll                      PASS      20.41 seconds
BluezMake                     PASS      1600.92 seconds
MakeCheck                     PASS      13.09 seconds
MakeDistcheck                 PASS      163.65 seconds
CheckValgrind                 PASS      220.84 seconds
CheckSmatch                   PASS      276.15 seconds
bluezmakeextell               PASS      99.11 seconds
IncrementalBuild              PENDING   0.31 seconds
ScanBuild                     PASS      860.07 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth
patchwork-bot+bluetooth@kernel.org Dec. 16, 2024, 9:50 p.m. UTC | #2 
Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Mon, 16 Dec 2024 20:53:30 +0530 you wrote:
> This change is required for passing below PTS testcase -
> 
> 1) MAP/MCE/MMB/BV-01-C
> Verify that the MCE can retrieve a Folders Listing on the MSE.
> 
> As of now, user is able to initiate only map messagelisting
> operation with command 'ls <folder_name>' and there is no way to initiate
> folder listing with 'ls' command as second argument <options> is
> set as compulsary.
> In the obexctl code, map folderlisting gets triggered only when there is no
> arguments followed by 'ls' command.
> Therefore in 'ls' command, make the second argument as optional.
> 
> [...]

Here is the summary with links:
  - [v2] obexctl: Enable Map folderlisting operation from obexctl
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=c2caa26a4d62

You are awesome, thank you!
diff mbox series

Patch

diff --git a/tools/obexctl.c b/tools/obexctl.c
index 9adf8088a..0965762ce 100644
--- a/tools/obexctl.c
+++ b/tools/obexctl.c
@@ -1873,7 +1873,7 @@  static const struct bt_shell_menu main_menu = {
 	{ "pull",	  "<file>",   cmd_pull,
 					"Pull Vobject & stores in file" },
 	{ "cd",           "<path>",   cmd_cd, "Change current folder" },
-	{ "ls",           "<options>", cmd_ls, "List current folder" },
+	{ "ls",           "[options]", cmd_ls, "List current folder" },
 	{ "cp",          "<source file> <destination file>",   cmd_cp,
 				"Copy source file to destination file" },
 	{ "mv",          "<source file> <destination file>",   cmd_mv,