Message ID | 20250108202442.v3.1.I66a83f84dce50455c9f7cc7b7ba8fc9d1d465db9@changeid (mailing list archive) |
---|---|
State | Accepted |
Commit | e52a5e074971c701c4d87ab63e2fbdd6049e8328 |
Headers | show |
Series | [v3,1/3] Bluetooth: Remove the cmd timeout count in btusb | expand |
Context | Check | Description |
---|---|---|
tedd_an/pre-ci_am | success | Success |
tedd_an/SubjectPrefix | success | Gitlint PASS |
tedd_an/BuildKernel | success | BuildKernel PASS |
tedd_an/CheckAllWarning | success | CheckAllWarning PASS |
tedd_an/CheckSparse | warning | CheckSparse WARNING net/bluetooth/hci_core.c:60:1: warning: symbol 'hci_cb_list_lock' was not declared. Should it be static? |
tedd_an/BuildKernel32 | success | BuildKernel32 PASS |
tedd_an/TestRunnerSetup | success | TestRunnerSetup PASS |
tedd_an/TestRunner_l2cap-tester | success | TestRunner PASS |
tedd_an/TestRunner_iso-tester | success | TestRunner PASS |
tedd_an/TestRunner_bnep-tester | success | TestRunner PASS |
tedd_an/TestRunner_mgmt-tester | fail | TestRunner_mgmt-tester: Total: 490, Passed: 485 (99.0%), Failed: 1, Not Run: 4 |
tedd_an/TestRunner_rfcomm-tester | success | TestRunner PASS |
tedd_an/TestRunner_sco-tester | success | TestRunner PASS |
tedd_an/TestRunner_ioctl-tester | success | TestRunner PASS |
tedd_an/TestRunner_mesh-tester | success | TestRunner PASS |
tedd_an/TestRunner_smp-tester | success | TestRunner PASS |
tedd_an/TestRunner_userchan-tester | success | TestRunner PASS |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=923368 ---Test result--- Test Summary: CheckPatch PENDING 0.25 seconds GitLint PENDING 0.22 seconds SubjectPrefix PASS 0.34 seconds BuildKernel PASS 25.01 seconds CheckAllWarning PASS 27.16 seconds CheckSparse WARNING 30.79 seconds BuildKernel32 PASS 24.60 seconds TestRunnerSetup PASS 433.69 seconds TestRunner_l2cap-tester PASS 22.60 seconds TestRunner_iso-tester PASS 27.70 seconds TestRunner_bnep-tester PASS 4.79 seconds TestRunner_mgmt-tester FAIL 118.68 seconds TestRunner_rfcomm-tester PASS 7.56 seconds TestRunner_sco-tester PASS 9.85 seconds TestRunner_ioctl-tester PASS 8.09 seconds TestRunner_mesh-tester PASS 5.94 seconds TestRunner_smp-tester PASS 6.98 seconds TestRunner_userchan-tester PASS 5.05 seconds IncrementalBuild PENDING 0.97 seconds Details ############################## Test: CheckPatch - PENDING Desc: Run checkpatch.pl script Output: ############################## Test: GitLint - PENDING Desc: Run gitlint Output: ############################## Test: CheckSparse - WARNING Desc: Run sparse tool with linux kernel Output: net/bluetooth/hci_core.c:60:1: warning: symbol 'hci_cb_list_lock' was not declared. Should it be static? ############################## Test: TestRunner_mgmt-tester - FAIL Desc: Run mgmt-tester with test-runner Output: Total: 490, Passed: 485 (99.0%), Failed: 1, Not Run: 4 Failed Test Cases LL Privacy - Set Flags 3 (2 Devices to RL) Failed 0.171 seconds ############################## Test: IncrementalBuild - PENDING Desc: Incremental build with the patches in the series Output: --- Regards, Linux Bluetooth
Hello: This series was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Wed, 8 Jan 2025 20:24:42 +0800 you wrote: > From: Hsin-chen Chuang <chharry@chromium.org> > > Remove the cmd timeout count in btusb since we only ever allow one > command in flight at a time. We should always reset after a single > command times out. > > Signed-off-by: Hsin-chen Chuang <chharry@chromium.org> > > [...] Here is the summary with links: - [v3,1/3] Bluetooth: Remove the cmd timeout count in btusb https://git.kernel.org/bluetooth/bluetooth-next/c/e52a5e074971 - [v3,2/3] Bluetooth: Get rid of cmd_timeout and use the reset callback https://git.kernel.org/bluetooth/bluetooth-next/c/fd224b09eedd - [v3,3/3] Bluetooth: Allow reset via sysfs https://git.kernel.org/bluetooth/bluetooth-next/c/c4e01540368c You are awesome, thank you!
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index de0b4d99fcbf..916e9ec7bc85 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -881,7 +881,6 @@ struct btusb_data { int (*disconnect)(struct hci_dev *hdev); int oob_wake_irq; /* irq for out-of-band wake-on-bt */ - unsigned cmd_timeout_cnt; struct qca_dump_info qca_dump; }; @@ -914,9 +913,6 @@ static void btusb_intel_cmd_timeout(struct hci_dev *hdev) struct gpio_desc *reset_gpio = data->reset_gpio; struct btintel_data *intel_data = hci_get_priv(hdev); - if (++data->cmd_timeout_cnt < 5) - return; - if (intel_data->acpi_reset_method) { if (test_and_set_bit(INTEL_ACPI_RESET_ACTIVE, intel_data->flags)) { bt_dev_err(hdev, "acpi: last reset failed ? Not resetting again"); @@ -999,9 +995,6 @@ static void btusb_rtl_cmd_timeout(struct hci_dev *hdev) btusb_rtl_alloc_devcoredump(hdev, &hdr, NULL, 0); - if (++data->cmd_timeout_cnt < 5) - return; - if (!reset_gpio) { btusb_reset(hdev); return; @@ -1046,9 +1039,6 @@ static void btusb_qca_cmd_timeout(struct hci_dev *hdev) return; } - if (++data->cmd_timeout_cnt < 5) - return; - if (reset_gpio) { bt_dev_err(hdev, "Reset qca device via bt_en gpio");