| Message ID | 20250212135209.129361-2-arkadiusz.bokowy@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8e76a4d0dc5603d8b2e3711d217cfe26b7c3b981 |
| Headers | show |
| Series | [1/4] test-runner: Increase amount of RAM available in VM | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
Hi Arkadiusz, On Wed, Feb 12, 2025 at 8:52 AM Arkadiusz Bokowy <arkadiusz.bokowy@gmail.com> wrote: > > This option causes QEMU to redirect monitor and serial to the terminal, > but also it modifies the terminal settings and clears it before printing > anything. Such behavior might be annoying because it might clear some > warning messages printed before clearing the screen. Since test-runner > disables QEMU monitor and redirects serial to stdio in an explicit way, > the "-nographic" option can be dropped. > --- > tools/test-runner.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tools/test-runner.c b/tools/test-runner.c > index 77c89f3f9..13a5de465 100644 > --- a/tools/test-runner.c > +++ b/tools/test-runner.c > @@ -212,7 +212,6 @@ static char *const qemu_argv[] = { > "-display", "none", > "-machine", "type=q35,accel=kvm:tcg", > "-m", "256M", > - "-nographic", > "-net", "none", > "-no-reboot", > "-fsdev", "local,id=fsdev-root,path=/,readonly,security_model=none," Are you sure this won't require changes to tester.config? It seems you have the impression the test-runner kernel image shall be compiled with distros .config on top of tester.config, that is not how the likes of CI uses it though, usually all you have to do is: https://github.com/bluez/bluez/blob/master/doc/test-runner.rst#kernel So we need to confirm removing -nographic doesn't end up breaking when build with only tester.config > -- > 2.43.0 > >
diff --git a/tools/test-runner.c b/tools/test-runner.c index 77c89f3f9..13a5de465 100644 --- a/tools/test-runner.c +++ b/tools/test-runner.c @@ -212,7 +212,6 @@ static char *const qemu_argv[] = { "-display", "none", "-machine", "type=q35,accel=kvm:tcg", "-m", "256M", - "-nographic", "-net", "none", "-no-reboot", "-fsdev", "local,id=fsdev-root,path=/,readonly,security_model=none,"