| Message ID | 20250213034413.3808375-1-chharry@google.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v4,1/3] Bluetooth: Fix possible race with userspace of sysfs isoc_alt | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/SubjectPrefix | success | Gitlint PASS |
On Thu, Feb 13, 2025 at 11:44:01AM +0800, Hsin-chen Chuang wrote: > From: Hsin-chen Chuang <chharry@chromium.org> > > The functionality was completed in commit c04f2e4f4ea1 ("Bluetooth: Fix > possible race with userspace of sysfs isoc_alt") > > Fixes: c04f2e4f4ea1 ("Bluetooth: Fix possible race with userspace of sysfs isoc_alt") Where is this git id? I don't see it in linux-next, are you sure it is correct? thanks, greg k-h
On Thu, Feb 13, 2025 at 6:01 PM Greg KH <gregkh@linuxfoundation.org> wrote: > > On Thu, Feb 13, 2025 at 11:44:01AM +0800, Hsin-chen Chuang wrote: > > From: Hsin-chen Chuang <chharry@chromium.org> > > > > The functionality was completed in commit c04f2e4f4ea1 ("Bluetooth: Fix > > possible race with userspace of sysfs isoc_alt") > > > > Fixes: c04f2e4f4ea1 ("Bluetooth: Fix possible race with userspace of sysfs isoc_alt") > > Where is this git id? I don't see it in linux-next, are you sure it is > correct? This hash is the first patch of this series. So I guess I should send this patch after the ancestors are all applied then. > > thanks, > > greg k-h
On Thu, Feb 13, 2025 at 06:07:59PM +0800, Hsin-chen Chuang wrote: > On Thu, Feb 13, 2025 at 6:01 PM Greg KH <gregkh@linuxfoundation.org> wrote: > > > > On Thu, Feb 13, 2025 at 11:44:01AM +0800, Hsin-chen Chuang wrote: > > > From: Hsin-chen Chuang <chharry@chromium.org> > > > > > > The functionality was completed in commit c04f2e4f4ea1 ("Bluetooth: Fix > > > possible race with userspace of sysfs isoc_alt") > > > > > > Fixes: c04f2e4f4ea1 ("Bluetooth: Fix possible race with userspace of sysfs isoc_alt") > > > > Where is this git id? I don't see it in linux-next, are you sure it is > > correct? > > This hash is the first patch of this series. That's not a valid git id as it only exists on your local system and no where else :( > So I guess I should send this patch after the ancestors are all > applied then. Or better yet, include the api addition as part of the patch that actually adds the new api. thanks, greg k-h
Got it. Thanks for the feedback On Thu, Feb 13, 2025 at 6:13 PM Greg KH <gregkh@linuxfoundation.org> wrote: > > On Thu, Feb 13, 2025 at 06:07:59PM +0800, Hsin-chen Chuang wrote: > > On Thu, Feb 13, 2025 at 6:01 PM Greg KH <gregkh@linuxfoundation.org> wrote: > > > > > > On Thu, Feb 13, 2025 at 11:44:01AM +0800, Hsin-chen Chuang wrote: > > > > From: Hsin-chen Chuang <chharry@chromium.org> > > > > > > > > The functionality was completed in commit c04f2e4f4ea1 ("Bluetooth: Fix > > > > possible race with userspace of sysfs isoc_alt") > > > > > > > > Fixes: c04f2e4f4ea1 ("Bluetooth: Fix possible race with userspace of sysfs isoc_alt") > > > > > > Where is this git id? I don't see it in linux-next, are you sure it is > > > correct? > > > > This hash is the first patch of this series. > > That's not a valid git id as it only exists on your local system and no > where else :( > > > So I guess I should send this patch after the ancestors are all > > applied then. > > Or better yet, include the api addition as part of the patch that > actually adds the new api. > > thanks, > > greg k-h
diff --git a/Documentation/ABI/stable/sysfs-class-bluetooth b/Documentation/ABI/stable/sysfs-class-bluetooth index 36be02471174..c1024c7c4634 100644 --- a/Documentation/ABI/stable/sysfs-class-bluetooth +++ b/Documentation/ABI/stable/sysfs-class-bluetooth @@ -7,3 +7,16 @@ Description: This write-only attribute allows users to trigger the vendor reset The reset may or may not be done through the device transport (e.g., UART/USB), and can also be done through an out-of-band approach such as GPIO. + +What: /sys/class/bluetooth/btusb<usb-intf>/isoc_alt +Date: 13-Feb-2025 +KernelVersion: 6.13 +Contact: linux-bluetooth@vger.kernel.org +Description: This attribute allows users to configure the USB Alternate setting + for the specific HCI device. Reading this attribute returns the + current setting, and writing any supported numbers would change + the setting. See the USB Alternate setting definition in Bluetooth + core spec 5, vol 4, part B, table 2.1. + If the HCI device is not yet init-ed, the write fails with -ENODEV. + If the data is not a valid number, the write fails with -EINVAL. + The other failures are vendor specific.