diff mbox series

[v1] obex: Add null check for data pointer for PCE

Message ID 20250228062554.3102800-1-quic_amisjain@quicinc.com (mailing list archive)
State Accepted
Commit 8d1c5165fcd80cc48fb3b7db7744c708c03ac310
Headers show
Series [v1] obex: Add null check for data pointer for PCE | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/BuildEll success Build ELL PASS
tedd_an/BluezMake success Bluez Make PASS
tedd_an/MakeCheck success Bluez Make Check PASS
tedd_an/MakeDistcheck success Make Distcheck PASS
tedd_an/CheckValgrind success Check Valgrind PASS
tedd_an/CheckSmatch success CheckSparse PASS
tedd_an/bluezmakeextell success Make External ELL PASS
tedd_an/ScanBuild success Scan Build PASS

Commit Message

Amisha Jain Feb. 28, 2025, 6:25 a.m. UTC
Incase of legacy server, when the 'supported fetures bit' attribute
is NULL, Add the check to avoid any invalid memory access.

---
 obexd/client/pbap.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

bluez.test.bot@gmail.com Feb. 28, 2025, 7:39 a.m. UTC | #1
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=938829

---Test result---

Test Summary:
CheckPatch                    PENDING   0.22 seconds
GitLint                       PENDING   0.17 seconds
BuildEll                      PASS      20.65 seconds
BluezMake                     PASS      1539.35 seconds
MakeCheck                     PASS      13.32 seconds
MakeDistcheck                 PASS      161.62 seconds
CheckValgrind                 PASS      216.12 seconds
CheckSmatch                   PASS      286.76 seconds
bluezmakeextell               PASS      99.66 seconds
IncrementalBuild              PENDING   0.26 seconds
ScanBuild                     PASS      881.24 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth
patchwork-bot+bluetooth@kernel.org Feb. 28, 2025, 3:20 p.m. UTC | #2
Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Fri, 28 Feb 2025 11:55:54 +0530 you wrote:
> Incase of legacy server, when the 'supported fetures bit' attribute
> is NULL, Add the check to avoid any invalid memory access.
> 
> ---
>  obexd/client/pbap.c | 3 +++
>  1 file changed, 3 insertions(+)

Here is the summary with links:
  - [v1] obex: Add null check for data pointer for PCE
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=8d1c5165fcd8

You are awesome, thank you!
diff mbox series

Patch

diff --git a/obexd/client/pbap.c b/obexd/client/pbap.c
index 09d3fd425..48a2de650 100644
--- a/obexd/client/pbap.c
+++ b/obexd/client/pbap.c
@@ -1235,6 +1235,9 @@  static void *pbap_supported_features(struct obc_session *session)
 	data = obc_session_get_attribute(session,
 					SDP_ATTR_PBAP_SUPPORTED_FEATURES);
 
+	if (!data)
+		return NULL;
+
 	features = *(uint32_t *) data;
 	if (!features)
 		return NULL;