diff mbox series

[BlueZ,1/3] shared/util: implement argsisutf8()

Message ID 20250318131431.124750-2-r.smirnov@omp.ru (mailing list archive)
State Accepted
Commit 0205edbd29fc972f9aad2b2d21789e97f45d3c24
Headers show
Series Fix crash in dbus caused by Unicode characters | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/BuildEll success Build ELL PASS
tedd_an/BluezMake success Bluez Make PASS
tedd_an/MakeCheck success Bluez Make Check PASS
tedd_an/MakeDistcheck success Make Distcheck PASS
tedd_an/CheckValgrind success Check Valgrind PASS
tedd_an/CheckSmatch warning CheckSparse WARNING src/shared/shell.c: note: in included file (through /usr/include/readline/readline.h):src/shared/shell.c: note: in included file (through /usr/include/readline/readline.h):src/shared/shell.c: note: in included file (through /usr/include/readline/readline.h):
tedd_an/bluezmakeextell success Make External ELL PASS
tedd_an/ScanBuild success Scan Build PASS

Commit Message

Roman Smirnov March 18, 2025, 1:14 p.m. UTC 
This implements argsisutf8() which checks that all strings in the
argv array are written in utf8.
---
 src/shared/util.c | 12 ++++++++++++
 src/shared/util.h |  1 +
 2 files changed, 13 insertions(+)

Comments

bluez.test.bot@gmail.com March 18, 2025, 2:22 p.m. UTC | #1 
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=945142

---Test result---

Test Summary:
CheckPatch                    PENDING   0.20 seconds
GitLint                       PENDING   0.28 seconds
BuildEll                      PASS      20.76 seconds
BluezMake                     PASS      1687.68 seconds
MakeCheck                     PASS      12.96 seconds
MakeDistcheck                 PASS      161.16 seconds
CheckValgrind                 PASS      219.29 seconds
CheckSmatch                   WARNING   285.71 seconds
bluezmakeextell               PASS      99.79 seconds
IncrementalBuild              PENDING   0.31 seconds
ScanBuild                     PASS      878.14 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
src/shared/shell.c: note: in included file (through /usr/include/readline/readline.h):src/shared/shell.c: note: in included file (through /usr/include/readline/readline.h):src/shared/shell.c: note: in included file (through /usr/include/readline/readline.h):
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth
diff mbox series

Patch

diff --git a/src/shared/util.c b/src/shared/util.c
index 6e7634ad1..5d3a14d96 100644
--- a/src/shared/util.c
+++ b/src/shared/util.c
@@ -1947,3 +1947,15 @@  bool strisutf8(const char *str, size_t len)
 
 	return true;
 }
+
+bool argsisutf8(int argc, char *argv[])
+{
+	for (int i = 0; i < argc; i++) {
+		if (!strisutf8(argv[i], strlen(argv[i]))) {
+			printf("Invalid character in string: %s\n", argv[i]);
+			return false;
+		}
+	}
+
+	return true;
+}
diff --git a/src/shared/util.h b/src/shared/util.h
index f2ca4f29f..dd357fb93 100644
--- a/src/shared/util.h
+++ b/src/shared/util.h
@@ -91,6 +91,7 @@  char *strdelimit(char *str, char *del, char c);
 int strsuffix(const char *str, const char *suffix);
 char *strstrip(char *str);
 bool strisutf8(const char *str, size_t length);
+bool argsisutf8(int argc, char *argv[]);
 
 void *util_malloc(size_t size);
 void *util_memdup(const void *src, size_t size);