| Message ID | 20250325083546.31597-2-ziyao@disroot.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [BlueZ] client/gatt: Fix pointer assigned with character literal | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | success | CheckSparse PASS |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/ScanBuild | success | Scan Build PASS |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=947070 ---Test result--- Test Summary: CheckPatch PENDING 0.22 seconds GitLint PENDING 0.20 seconds BuildEll PASS 20.59 seconds BluezMake PASS 1501.71 seconds MakeCheck PASS 14.08 seconds MakeDistcheck PASS 160.64 seconds CheckValgrind PASS 215.44 seconds CheckSmatch PASS 286.46 seconds bluezmakeextell PASS 98.54 seconds IncrementalBuild PENDING 0.71 seconds ScanBuild PASS 898.19 seconds Details ############################## Test: CheckPatch - PENDING Desc: Run checkpatch.pl script Output: ############################## Test: GitLint - PENDING Desc: Run gitlint Output: ############################## Test: IncrementalBuild - PENDING Desc: Incremental build with the patches in the series Output: --- Regards, Linux Bluetooth
On Tuesday, 25 March 2025, 09:35:47 CET, Yao Zi wrote: > A character literl, '\0', is assigned to the pointer. The corresponding > comment doesn't make any sense, since '\0' represents zero and this > statement does the same thing as assigning value with NULL. > > Initializing value with NULL (or zero) is safe and correct here: the > only case that the initial value of the pointer is passed to > write_value() is that the if branch isn't executed, where len keeps its > initial value, zero, as well. With src_len equal to zero, write_value() > will bail out and src_val won't be dereferenced. > > Let's clean up the misleading comment and change right side of the > assignment to fix compiler warnings about the wrong type, > > Fixes: ee750bbaf68c ("client/gatt: proxy_property_changed: check for NULL iterator") > Signed-off-by: Yao Zi <ziyao@disroot.org> After reading my own commit message, assigning "value = '\0'" absolutely makes no sense in this context. Actually my intention was only checking for iter != NULL. Acked-by: Christian Eggers <ceggers@arri.de> > --- > client/gatt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/client/gatt.c b/client/gatt.c > index 4dac88590..b18186518 100644 > --- a/client/gatt.c > +++ b/client/gatt.c > @@ -3207,7 +3207,7 @@ static void proxy_property_changed(GDBusProxy *proxy, const char *name, > chrc->path, bt_uuidstr_to_str(chrc->uuid), name); > > if (!strcmp(name, "Value")) { > - uint8_t *value = '\0'; /* don't pass NULL to write_value() */ > + uint8_t *value = NULL; > int len = 0; > > if (iter && dbus_message_iter_get_arg_type(iter) == >
diff --git a/client/gatt.c b/client/gatt.c index 4dac88590..b18186518 100644 --- a/client/gatt.c +++ b/client/gatt.c @@ -3207,7 +3207,7 @@ static void proxy_property_changed(GDBusProxy *proxy, const char *name, chrc->path, bt_uuidstr_to_str(chrc->uuid), name); if (!strcmp(name, "Value")) { - uint8_t *value = '\0'; /* don't pass NULL to write_value() */ + uint8_t *value = NULL; int len = 0; if (iter && dbus_message_iter_get_arg_type(iter) ==
A character literl, '\0', is assigned to the pointer. The corresponding comment doesn't make any sense, since '\0' represents zero and this statement does the same thing as assigning value with NULL. Initializing value with NULL (or zero) is safe and correct here: the only case that the initial value of the pointer is passed to write_value() is that the if branch isn't executed, where len keeps its initial value, zero, as well. With src_len equal to zero, write_value() will bail out and src_val won't be dereferenced. Let's clean up the misleading comment and change right side of the assignment to fix compiler warnings about the wrong type, Fixes: ee750bbaf68c ("client/gatt: proxy_property_changed: check for NULL iterator") Signed-off-by: Yao Zi <ziyao@disroot.org> --- client/gatt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)