| Message ID | 3591c206eeccdacb8b4e702494d799792b752661.1656583541.git.hakan.jansson@infineon.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | f5d25901c5ccbefc2f83294d83d9c50456e1f12b |
| Headers | show |
| Series | Bluetooth: hci_bcm: Improve FW load time on CYW55572 | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/checkpatch | success | Checkpatch PASS |
| tedd_an/gitlint | success | Gitlint PASS |
| tedd_an/subjectprefix | fail | "Bluetooth: " is not specified in the subject |
On Thu, 30 Jun 2022 14:45:21 +0200, Hakan Jansson wrote: > Add conditional constraint to make property "reset-gpios" available only > for compatible devices acually having the reset pin. > > Make property "brcm,requires-autobaud-mode" depend on property > "shutdown-gpios" as the shutdown pin is required to enter autobaud mode. > > I looked at all compatible devices and compiled the matrix below before > formulating the conditional constraint. This was a pure paper exercise and > no verification testing has been performed. > > d > e > v h > i o > c s > s e t > h - - > u w w v > t r a a v d > d e k k b d > o s e e a i > w e u u t o > n t p p - - > - - - - s s > g g g g u u > p p p p t p p > i i i i x l p p > o o o o c p l l > s s s s o o y y > --------------------------------------- > brcm,bcm20702a1 X X X X X X X X > brcm,bcm4329-bt X X X X X X X X > brcm,bcm4330-bt X X X X X X X X > brcm,bcm4334-bt X - X X X X X X > brcm,bcm43438-bt X - X X X X X X > brcm,bcm4345c5 X - X X X X X X > brcm,bcm43540-bt X - X X X X X X > brcm,bcm4335a0 X - X X X X X X > brcm,bcm4349-bt X - X X X X X X > infineon,cyw55572-bt X - X X X X X X > > Signed-off-by: Hakan Jansson <hakan.jansson@infineon.com> > --- > V1 -> V2: > - New patch added to series > > .../bindings/net/broadcom-bluetooth.yaml | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org>
On Thu, Jun 30, 2022 at 2:46 PM Hakan Jansson <hakan.jansson@infineon.com> wrote: > Add conditional constraint to make property "reset-gpios" available only > for compatible devices acually having the reset pin. > > Make property "brcm,requires-autobaud-mode" depend on property > "shutdown-gpios" as the shutdown pin is required to enter autobaud mode. > > I looked at all compatible devices and compiled the matrix below before > formulating the conditional constraint. This was a pure paper exercise and > no verification testing has been performed. > > d > e > v h > i o > c s > s e t > h - - > u w w v > t r a a v d > d e k k b d > o s e e a i > w e u u t o > n t p p - - > - - - - s s > g g g g u u > p p p p t p p > i i i i x l p p > o o o o c p l l > s s s s o o y y > --------------------------------------- > brcm,bcm20702a1 X X X X X X X X > brcm,bcm4329-bt X X X X X X X X > brcm,bcm4330-bt X X X X X X X X > brcm,bcm4334-bt X - X X X X X X > brcm,bcm43438-bt X - X X X X X X > brcm,bcm4345c5 X - X X X X X X > brcm,bcm43540-bt X - X X X X X X > brcm,bcm4335a0 X - X X X X X X > brcm,bcm4349-bt X - X X X X X X > infineon,cyw55572-bt X - X X X X X X > > Signed-off-by: Hakan Jansson <hakan.jansson@infineon.com> A job well done! Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
diff --git a/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml b/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml index 71fe9b17f8f1..445b2a553625 100644 --- a/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml +++ b/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml @@ -117,6 +117,22 @@ properties: required: - compatible +dependencies: + brcm,requires-autobaud-mode: [ 'shutdown-gpios' ] + +if: + not: + properties: + compatible: + contains: + enum: + - brcm,bcm20702a1 + - brcm,bcm4329-bt + - brcm,bcm4330-bt +then: + properties: + reset-gpios: false + additionalProperties: false examples:
Add conditional constraint to make property "reset-gpios" available only for compatible devices acually having the reset pin. Make property "brcm,requires-autobaud-mode" depend on property "shutdown-gpios" as the shutdown pin is required to enter autobaud mode. I looked at all compatible devices and compiled the matrix below before formulating the conditional constraint. This was a pure paper exercise and no verification testing has been performed. d e v h i o c s s e t h - - u w w v t r a a v d d e k k b d o s e e a i w e u u t o n t p p - - - - - - s s g g g g u u p p p p t p p i i i i x l p p o o o o c p l l s s s s o o y y --------------------------------------- brcm,bcm20702a1 X X X X X X X X brcm,bcm4329-bt X X X X X X X X brcm,bcm4330-bt X X X X X X X X brcm,bcm4334-bt X - X X X X X X brcm,bcm43438-bt X - X X X X X X brcm,bcm4345c5 X - X X X X X X brcm,bcm43540-bt X - X X X X X X brcm,bcm4335a0 X - X X X X X X brcm,bcm4349-bt X - X X X X X X infineon,cyw55572-bt X - X X X X X X Signed-off-by: Hakan Jansson <hakan.jansson@infineon.com> --- V1 -> V2: - New patch added to series .../bindings/net/broadcom-bluetooth.yaml | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)