| Message ID | 3df45c4a6737b249b519d4c6128e2eb783198abc.1676112710.git.pav@iki.fi (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 3e2e3aa739040605e0fb0f8f1e69bfd9a7e607d1 |
| Headers | show |
| Series | [BlueZ,v2,1/9] doc: remove unimplemented Quality Report from MGMT settings | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | warning | WARNING:UNKNOWN_COMMIT_ID: Unknown commit id '0454e2d09570', maybe rebased or not pulled? #48: commit 0454e2d09570 ("mgmt: Add support for Mesh in the kernel"), /github/workspace/src/src/13136997.patch total: 0 errors, 1 warnings, 14 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. /github/workspace/src/src/13136997.patch has style problems, please review. NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | warning | CheckSparse WARNING monitor/packet.c: note: in included file:monitor/display.h:82:26: warning: Variable length array is used.monitor/packet.c:1799:26: warning: Variable length array is used.monitor/packet.c: note: in included file:monitor/bt.h:3551:52: warning: array of flexible structuresmonitor/bt.h:3539:40: warning: array of flexible structures |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
| tedd_an/ScanBuild | success | Scan Build PASS |
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=720945
---Test result---
Test Summary:
CheckPatch FAIL 4.60 seconds
GitLint FAIL 3.23 seconds
BuildEll PASS 26.90 seconds
BluezMake PASS 865.81 seconds
MakeCheck PASS 11.33 seconds
MakeDistcheck PASS 148.69 seconds
CheckValgrind PASS 244.11 seconds
CheckSmatch WARNING 328.31 seconds
bluezmakeextell PASS 97.56 seconds
IncrementalBuild PASS 6443.84 seconds
ScanBuild PASS 996.32 seconds
Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[BlueZ,v2,1/9] doc: remove unimplemented Quality Report from MGMT settings
WARNING:UNKNOWN_COMMIT_ID: Unknown commit id '0454e2d09570', maybe rebased or not pulled?
#48:
commit 0454e2d09570 ("mgmt: Add support for Mesh in the kernel"),
/github/workspace/src/src/13136997.patch total: 0 errors, 1 warnings, 14 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/src/13136997.patch has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
[BlueZ,v2,5/9] tools/btmgmt: add MGMT setting bit names for CIS feature support
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#56:
supported settings: powered connectable fast-connectable discoverable bondable link-security ssp br/edr le advertising secure-conn debug-keys privacy configuration static-addr phy-configuration wide-band-speech cis-central cis-peripheral
/github/workspace/src/src/13137000.patch total: 0 errors, 1 warnings, 8 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/src/13137000.patch has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
[BlueZ,v2,3/9] lib: Add defines for MGMT setting bits for CIS feature support
WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
7: B2 Line has trailing whitespace: " "
[BlueZ,v2,5/9] tools/btmgmt: add MGMT setting bit names for CIS feature support
WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
7: B3 Line contains hard tab characters (\t): "hci0: Primary controller"
8: B3 Line contains hard tab characters (\t): " addr XX:XX:XX:XX:XX:XX version 12 manufacturer 2 class 0x7c0104"
9: B1 Line exceeds max length (238>80): " supported settings: powered connectable fast-connectable discoverable bondable link-security ssp br/edr le advertising secure-conn debug-keys privacy configuration static-addr phy-configuration wide-band-speech cis-central cis-peripheral"
9: B3 Line contains hard tab characters (\t): " supported settings: powered connectable fast-connectable discoverable bondable link-security ssp br/edr le advertising secure-conn debug-keys privacy configuration static-addr phy-configuration wide-band-speech cis-central cis-peripheral"
10: B1 Line exceeds max length (88>80): " current settings: powered bondable ssp br/edr le secure-conn cis-central cis-peripheral"
10: B3 Line contains hard tab characters (\t): " current settings: powered bondable ssp br/edr le secure-conn cis-central cis-peripheral"
11: B3 Line contains hard tab characters (\t): " name xxx"
12: B3 Line contains hard tab characters (\t): " short name"
13: B3 Line contains hard tab characters (\t): "hci0: Configuration options"
14: B3 Line contains hard tab characters (\t): " supported options: public-address"
15: B3 Line contains hard tab characters (\t): " missing options:"
[BlueZ,v2,6/9] adapter: add function for checking adapter features, add CIS features
WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
1: T1 Title exceeds max length (84>80): "[BlueZ,v2,6/9] adapter: add function for checking adapter features, add CIS features"
[BlueZ,v2,8/9] shared/bap: support client-only case
WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
19: B2 Line has trailing whitespace: " "
23: B2 Line has trailing whitespace: " "
[BlueZ,v2,9/9] bap: handle adapters that are not CIS Central / Peripheral capable
WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
1: T1 Title exceeds max length (81>80): "[BlueZ,v2,9/9] bap: handle adapters that are not CIS Central / Peripheral capable"
16: B2 Line has trailing whitespace: " "
22: B2 Line has trailing whitespace: " "
27: B2 Line has trailing whitespace: " "
30: B2 Line has trailing whitespace: " "
32: B2 Line has trailing whitespace: " "
34: B2 Line has trailing whitespace: " "
51: B3 Line contains hard tab characters (\t): " Name: xxx"
52: B3 Line contains hard tab characters (\t): " Alias: xxx"
53: B3 Line contains hard tab characters (\t): " Class: 0x00000000"
54: B3 Line contains hard tab characters (\t): " Powered: yes"
55: B3 Line contains hard tab characters (\t): " PowerState: on"
56: B3 Line contains hard tab characters (\t): " Discoverable: no"
57: B3 Line contains hard tab characters (\t): " DiscoverableTimeout: 0x000000b4"
58: B3 Line contains hard tab characters (\t): " Pairable: no"
59: B3 Line contains hard tab characters (\t): " UUID: Generic Attribute Profile (00001801-0000-1000-8000-00805f9b34fb)"
60: B3 Line contains hard tab characters (\t): " UUID: Generic Access Profile (00001800-0000-1000-8000-00805f9b34fb)"
61: B3 Line contains hard tab characters (\t): " UUID: Volume Control (00001844-0000-1000-8000-00805f9b34fb)"
62: B3 Line contains hard tab characters (\t): " UUID: Device Information (0000180a-0000-1000-8000-00805f9b34fb)"
63: B3 Line contains hard tab characters (\t): " UUID: Audio Stream Control (0000184e-0000-1000-8000-00805f9b34fb)"
64: B3 Line contains hard tab characters (\t): " UUID: Published Audio Capabil.. (00001850-0000-1000-8000-00805f9b34fb)"
65: B3 Line contains hard tab characters (\t): " Modalias: usb:v1D6Bp0246d0542"
66: B3 Line contains hard tab characters (\t): " Discovering: no"
67: B3 Line contains hard tab characters (\t): " Roles: central"
68: B3 Line contains hard tab characters (\t): " Roles: peripheral"
69: B1 Line exceeds max length (91>80): " ExperimentalFeatures: BlueZ Experimental LL p.. (15c0a148-c273-11ea-b3de-0242ac130004)"
69: B3 Line contains hard tab characters (\t): " ExperimentalFeatures: BlueZ Experimental LL p.. (15c0a148-c273-11ea-b3de-0242ac130004)"
70: B1 Line exceeds max length (91>80): " ExperimentalFeatures: BlueZ Experimental Blue.. (330859bc-7506-492d-9370-9a6f0614037f)"
70: B3 Line contains hard tab characters (\t): " ExperimentalFeatures: BlueZ Experimental Blue.. (330859bc-7506-492d-9370-9a6f0614037f)"
71: B1 Line exceeds max length (91>80): " ExperimentalFeatures: BlueZ Experimental ISO... (6fbaf188-05e0-496a-9885-d6ddfdb4e03e)"
71: B3 Line contains hard tab characters (\t): " ExperimentalFeatures: BlueZ Experimental ISO... (6fbaf188-05e0-496a-9885-d6ddfdb4e03e)"
72: B2 Line has trailing whitespace: " "
74: B2 Line has trailing whitespace: " "
99: B1 Line exceeds max length (82>80): " UUID: Generic Attribute Profile (00001801-0000-1000-8000-00805f9b34fb)"
100: B1 Line exceeds max length (82>80): " UUID: Generic Access Profile (00001800-0000-1000-8000-00805f9b34fb)"
101: B1 Line exceeds max length (82>80): " UUID: Volume Control (00001844-0000-1000-8000-00805f9b34fb)"
102: B1 Line exceeds max length (82>80): " UUID: Device Information (0000180a-0000-1000-8000-00805f9b34fb)"
107: B1 Line exceeds max length (98>80): " ExperimentalFeatures: BlueZ Experimental ISO... (6fbaf188-05e0-496a-9885-d6ddfdb4e03e)"
108: B2 Line has trailing whitespace: " "
110: B2 Line has trailing whitespace: " "
122: B1 Line exceeds max length (90>80): " [server]# transport.acquire /org/bluez/hci0/dev_XX_XX_XX_XX_XX_XX/pac_source0/fd12"
124: B1 Line exceeds max length (90>80): " [CHG] Transport /org/bluez/hci0/dev_XX_XX_XX_XX_XX_XX/pac_sink0/fd13 State: active"
125: B1 Line exceeds max length (92>80): " [CHG] Transport /org/bluez/hci0/dev_XX_XX_XX_XX_XX_XX/pac_source0/fd12 State: active"
126: B2 Line has trailing whitespace: " "
128: B2 Line has trailing whitespace: " "
138: B2 Line has trailing whitespace: " "
##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
monitor/packet.c: note: in included file:monitor/display.h:82:26: warning: Variable length array is used.monitor/packet.c:1799:26: warning: Variable length array is used.monitor/packet.c: note: in included file:monitor/bt.h:3551:52: warning: array of flexible structuresmonitor/bt.h:3539:40: warning: array of flexible structures
---
Regards,
Linux Bluetooth
Hello: This series was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Sat, 11 Feb 2023 10:53:45 +0000 you wrote: > The Set Quality Report command was removed in > commit 0454e2d09570 ("mgmt: Add support for Mesh in the kernel"), > but the settings bit was not removed. It's also not implemented on > kernel side, so remove it now. > --- > > Notes: > v2: split to two commits > > [...] Here is the summary with links: - [BlueZ,v2,1/9] doc: remove unimplemented Quality Report from MGMT settings https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=3e2e3aa73904 - [BlueZ,v2,2/9] doc: add MGMT setting for CIS features https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=97ad0ecbfdd4 - [BlueZ,v2,3/9] lib: Add defines for MGMT setting bits for CIS feature support https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=c35d32b19989 - [BlueZ,v2,4/9] monitor: add MGMT setting bit names for CIS feature support https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=0f2f7a8fe270 - [BlueZ,v2,5/9] tools/btmgmt: add MGMT setting bit names for CIS feature support https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=6f131929b832 - [BlueZ,v2,6/9] adapter: add function for checking adapter features, add CIS features (no matching commit) - [BlueZ,v2,7/9] media: Check adapter CIS support to add BAP in SupportedUUIDs (no matching commit) - [BlueZ,v2,8/9] shared/bap: support client-only case (no matching commit) - [BlueZ,v2,9/9] bap: handle adapters that are not CIS Central / Peripheral capable (no matching commit) You are awesome, thank you!
Hi Pauli, On Mon, Feb 13, 2023 at 2:21 PM <patchwork-bot+bluetooth@kernel.org> wrote: > > Hello: > > This series was applied to bluetooth/bluez.git (master) > by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: > > On Sat, 11 Feb 2023 10:53:45 +0000 you wrote: > > The Set Quality Report command was removed in > > commit 0454e2d09570 ("mgmt: Add support for Mesh in the kernel"), > > but the settings bit was not removed. It's also not implemented on > > kernel side, so remove it now. > > --- > > > > Notes: > > v2: split to two commits > > > > [...] > > Here is the summary with links: > - [BlueZ,v2,1/9] doc: remove unimplemented Quality Report from MGMT settings > https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=3e2e3aa73904 > - [BlueZ,v2,2/9] doc: add MGMT setting for CIS features > https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=97ad0ecbfdd4 > - [BlueZ,v2,3/9] lib: Add defines for MGMT setting bits for CIS feature support > https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=c35d32b19989 > - [BlueZ,v2,4/9] monitor: add MGMT setting bit names for CIS feature support > https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=0f2f7a8fe270 > - [BlueZ,v2,5/9] tools/btmgmt: add MGMT setting bit names for CIS feature support > https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=6f131929b832 > - [BlueZ,v2,6/9] adapter: add function for checking adapter features, add CIS features > (no matching commit) > - [BlueZ,v2,7/9] media: Check adapter CIS support to add BAP in SupportedUUIDs > (no matching commit) > - [BlueZ,v2,8/9] shared/bap: support client-only case > (no matching commit) > - [BlueZ,v2,9/9] bap: handle adapters that are not CIS Central / Peripheral capable > (no matching commit) > > You are awesome, thank you! Note that I did change some of the commits, for instance I went with btd_adapter_has_settings so we can use the MGMT defines directly, instead of creating a new enum.
diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt index 90d612ed8..0e0b4fdf0 100644 --- a/doc/mgmt-api.txt +++ b/doc/mgmt-api.txt @@ -332,7 +332,6 @@ Read Controller Information Command 15 Static Address 16 PHY Configuration 17 Wideband Speech - 18 Quality Report This command generates a Command Complete event on success or a Command Status event on failure. @@ -2925,7 +2924,6 @@ Read Extended Controller Information Command 15 Static Address 16 PHY Configuration 17 Wideband Speech - 18 Quality Report The EIR_Data field contains information about class of device, local name and other values. Not all of them might be present. For
The Set Quality Report command was removed in commit 0454e2d09570 ("mgmt: Add support for Mesh in the kernel"), but the settings bit was not removed. It's also not implemented on kernel side, so remove it now. --- Notes: v2: split to two commits doc/mgmt-api.txt | 2 -- 1 file changed, 2 deletions(-)