[1/2] Bluetooth: btbcm: Use strreplace()

Commit Message

Christophe JAILLET Feb. 17, 2024, 7:30 a.m. UTC

Use strreplace() instead of hand-writing it.
It is less verbose.

Signed-off-by: Christophe JAILLET <[e-mail]>
---
 drivers/bluetooth/btbcm.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

Comments

[e-mail] Feb. 17, 2024, 7:58 a.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=827028

---Test result---

Test Summary:
CheckPatch                    PASS      1.32 seconds
GitLint                       PASS      0.66 seconds
SubjectPrefix                 PASS      0.26 seconds
BuildKernel                   PASS      28.01 seconds
CheckAllWarning               PASS      30.39 seconds
CheckSparse                   PASS      36.25 seconds
CheckSmatch                   PASS      98.35 seconds
BuildKernel32                 PASS      26.96 seconds
TestRunnerSetup               PASS      496.21 seconds
TestRunner_l2cap-tester       PASS      18.13 seconds
TestRunner_iso-tester         PASS      29.16 seconds
TestRunner_bnep-tester        PASS      4.84 seconds
TestRunner_mgmt-tester        FAIL      161.51 seconds
TestRunner_rfcomm-tester      PASS      7.44 seconds
TestRunner_sco-tester         PASS      15.04 seconds
TestRunner_ioctl-tester       PASS      7.76 seconds
TestRunner_mesh-tester        PASS      6.00 seconds
TestRunner_smp-tester         PASS      6.93 seconds
TestRunner_userchan-tester    PASS      5.03 seconds
IncrementalBuild              PASS      30.73 seconds

Details
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 492, Passed: 485 (98.6%), Failed: 5, Not Run: 2

Failed Test Cases
LL Privacy - Add Device 4 (2 Devices to AL)          Failed       0.113 seconds
LL Privacy - Add Device 5 (2 Devices to RL)          Failed       0.111 seconds
LL Privacy - Add Device 6 (RL is full)               Failed       0.143 seconds
LL Privacy - Add Device 7 (AL is full)               Failed       0.151 seconds
LL Privacy - Remove Device 4 (Disable Adv)           Timed out    2.343 seconds


---
Regards,
Linux Bluetooth

[e-mail] Feb. 20, 2024, 7:10 p.m. UTC | #2

Hello:

This series was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[e-mail]>:

On Sat, 17 Feb 2024 08:30:41 +0100 you wrote:
> Use strreplace() instead of hand-writing it.
> It is less verbose.
> 
> Signed-off-by: Christophe JAILLET <[e-mail]>
> ---
>  drivers/bluetooth/btbcm.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)

Here is the summary with links:
  - [1/2] Bluetooth: btbcm: Use strreplace()
    https://git.kernel.org/bluetooth/bluetooth-next/c/76912dcbabc6
  - [2/2] Bluetooth: btbcm: Use devm_kstrdup()
    https://git.kernel.org/bluetooth/bluetooth-next/c/d095e06a1569

You are awesome, thank you!

Patch

diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c
index 0a5445ac5e1b..01d2343b4978 100644
--- a/drivers/bluetooth/btbcm.c
+++ b/drivers/bluetooth/btbcm.c
@@ -11,6 +11,7 @@ 
 #include <linux/firmware.h>
 #include <linux/dmi.h>
 #include <linux/of.h>
+#include <linux/string.h>
 #include <asm/unaligned.h>
 
 #include <net/bluetooth/bluetooth.h>
@@ -544,7 +545,6 @@  static const char *btbcm_get_board_name(struct device *dev)
 	char *board_type;
 	const char *tmp;
 	int len;
-	int i;
 
 	root = of_find_node_by_path("/");
 	if (!root)
@@ -557,10 +557,7 @@  static const char *btbcm_get_board_name(struct device *dev)
 	len = strlen(tmp) + 1;
 	board_type = devm_kzalloc(dev, len, GFP_KERNEL);
 	strscpy(board_type, tmp, len);
-	for (i = 0; i < len; i++) {
-		if (board_type[i] == '/')
-			board_type[i] = '-';
-	}
+	strreplace(board_type, '/', '-');
 	of_node_put(root);
 
 	return board_type;