| Message ID | 9dc80086204f29041b29570575df9112c6988955.1731177363.git.pav@iki.fi (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 774ad9fdd96a522f944a1d09fe374f6a88e61807 |
| Headers | show |
| Series | [BlueZ] transport: fix AVRCP volume in reconfigured transports | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | warning | WARNING:UNKNOWN_COMMIT_ID: Unknown commit id '469a75ae182a', maybe rebased or not pulled? #90: Fixes: 469a75ae182a ("sink: Fix transitioning to BTD_SERVICE_STATE_DISCONNECTED on idle") /github/workspace/src/src/13869699.patch total: 0 errors, 1 warnings, 11 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. /github/workspace/src/src/13869699.patch has style problems, please review. NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | success | CheckSparse PASS |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
| tedd_an/ScanBuild | success | Scan Build PASS |
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=908094
---Test result---
Test Summary:
CheckPatch FAIL 0.51 seconds
GitLint PASS 0.19 seconds
BuildEll PASS 24.70 seconds
BluezMake PASS 1658.88 seconds
MakeCheck PASS 12.87 seconds
MakeDistcheck PASS 179.41 seconds
CheckValgrind PASS 253.43 seconds
CheckSmatch PASS 356.85 seconds
bluezmakeextell PASS 120.57 seconds
IncrementalBuild PASS 1410.07 seconds
ScanBuild PASS 1002.89 seconds
Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[BlueZ] transport: fix AVRCP volume in reconfigured transports
WARNING:UNKNOWN_COMMIT_ID: Unknown commit id '469a75ae182a', maybe rebased or not pulled?
#90:
Fixes: 469a75ae182a ("sink: Fix transitioning to BTD_SERVICE_STATE_DISCONNECTED on idle")
/github/workspace/src/src/13869699.patch total: 0 errors, 1 warnings, 11 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/src/13869699.patch has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
---
Regards,
Linux Bluetooth
Hello: This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Sat, 9 Nov 2024 20:40:29 +0200 you wrote: > We no longer reconnect AVRCP session on AVDTP transport reconfiguration. > This breaks AVRCP volume after reconfiguration, since there's no volume > update event incoming. > > Fix by keeping track of the latest volume in btd_device volume. It was > introduced to track volume changes that arrive when there are no > transports/players, but we should track all volume changes otherwise the > value can be out of date when we want to use it. > > [...] Here is the summary with links: - [BlueZ] transport: fix AVRCP volume in reconfigured transports https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=774ad9fdd96a You are awesome, thank you!
diff --git a/profiles/audio/transport.c b/profiles/audio/transport.c index 8597313d8..dbebb1ea5 100644 --- a/profiles/audio/transport.c +++ b/profiles/audio/transport.c @@ -2598,10 +2598,9 @@ void media_transport_update_device_volume(struct btd_device *dev, /* Volume is A2DP only */ if (media_endpoint_get_sep(transport->endpoint)) { media_transport_update_volume(transport, volume); - return; + break; } } - /* If transport volume doesn't exists add to device_volume */ btd_device_set_volume(dev, volume); }
We no longer reconnect AVRCP session on AVDTP transport reconfiguration. This breaks AVRCP volume after reconfiguration, since there's no volume update event incoming. Fix by keeping track of the latest volume in btd_device volume. It was introduced to track volume changes that arrive when there are no transports/players, but we should track all volume changes otherwise the value can be out of date when we want to use it. Fixes: 469a75ae182a ("sink: Fix transitioning to BTD_SERVICE_STATE_DISCONNECTED on idle") --- profiles/audio/transport.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)