| Message ID | YuEq2Aey0VOrxPB+@kili (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 13474ba176c9649479db7cd2cef2210a4c9f3bbc |
| Headers | show |
| Series | [1/2] Bluetooth: ISO: unlock on error path in iso_sock_setsockopt() | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/checkpatch | success | Checkpatch PASS |
| tedd_an/gitlint | success | Gitlint PASS |
| tedd_an/subjectprefix | success | PASS |
| tedd_an/buildkernel | success | Build Kernel PASS |
| tedd_an/buildkernel32 | success | Build Kernel32 PASS |
| tedd_an/incremental_build | success | Pass |
| tedd_an/testrunnersetup | success | Test Runner Setup PASS |
| tedd_an/testrunnerl2cap-tester | success | Total: 40, Passed: 40 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunnerbnep-tester | success | Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunnermgmt-tester | success | Total: 494, Passed: 494 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunnerrfcomm-tester | success | Total: 10, Passed: 10 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunnersco-tester | success | Total: 12, Passed: 12 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunnersmp-tester | success | Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunneruserchan-tester | success | Total: 4, Passed: 4 (100.0%), Failed: 0, Not Run: 0 |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=663427 ---Test result--- Test Summary: CheckPatch PASS 3.49 seconds GitLint PASS 1.67 seconds SubjectPrefix PASS 1.21 seconds BuildKernel PASS 35.53 seconds BuildKernel32 PASS 31.02 seconds Incremental Build with patchesPASS 48.90 seconds TestRunner: Setup PASS 509.47 seconds TestRunner: l2cap-tester PASS 17.95 seconds TestRunner: bnep-tester PASS 6.84 seconds TestRunner: mgmt-tester PASS 106.23 seconds TestRunner: rfcomm-tester PASS 10.13 seconds TestRunner: sco-tester PASS 9.97 seconds TestRunner: smp-tester PASS 9.88 seconds TestRunner: userchan-tester PASS 6.87 seconds --- Regards, Linux Bluetooth
Hello: This series was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Wed, 27 Jul 2022 15:08:56 +0300 you wrote: > Call release_sock(sk); before returning on this error path. > > Fixes: ccf74f2390d6 ("Bluetooth: Add BTPROTO_ISO socket type") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > net/bluetooth/iso.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) Here is the summary with links: - [1/2] Bluetooth: ISO: unlock on error path in iso_sock_setsockopt() https://git.kernel.org/bluetooth/bluetooth-next/c/13474ba176c9 - [2/2] Bluetooth: ISO: fix info leak in iso_sock_getsockopt() (no matching commit) You are awesome, thank you!
diff --git a/net/bluetooth/iso.c b/net/bluetooth/iso.c index ff09c353e64e..19d003727b50 100644 --- a/net/bluetooth/iso.c +++ b/net/bluetooth/iso.c @@ -1177,8 +1177,10 @@ static int iso_sock_setsockopt(struct socket *sock, int level, int optname, } len = min_t(unsigned int, sizeof(qos), optlen); - if (len != sizeof(qos)) - return -EINVAL; + if (len != sizeof(qos)) { + err = -EINVAL; + break; + } memset(&qos, 0, sizeof(qos));
Call release_sock(sk); before returning on this error path. Fixes: ccf74f2390d6 ("Bluetooth: Add BTPROTO_ISO socket type") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- net/bluetooth/iso.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)