| Message ID | zEEbuiH5Idm8MyWzcjDThSGXk1jtLq8YxNQPGtHSClFG3F-22Zb3kYwj_IR_YVLszbAnWC-9cqTvWS-RjiZHlNqX8Ftduyy6fwIL8iDHkns=@proton.me (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | btusb: HCI_QUICK_NO_SUSPEND_NOTIFIER causes kernel panic | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | fail | error: patch failed: drivers/bluetooth/btusb.c:2267 error: drivers/bluetooth/btusb.c: patch does not apply hint: Use 'git am --show-current-patch' to see the failed patch |
This is an automated email and please do not reply to this email. Dear Submitter, Thank you for submitting the patches to the linux bluetooth mailing list. While preparing the CI tests, the patches you submitted couldn't be applied to the current HEAD of the repository. ----- Output ----- error: patch failed: drivers/bluetooth/btusb.c:2267 error: drivers/bluetooth/btusb.c: patch does not apply hint: Use 'git am --show-current-patch' to see the failed patch Please resolve the issue and submit the patches again. --- Regards, Linux Bluetooth
Hi Mihir, On Sat, Nov 19, 2022 at 9:15 AM <bluez.test.bot@gmail.com> wrote: > > This is an automated email and please do not reply to this email. > > Dear Submitter, > > Thank you for submitting the patches to the linux bluetooth mailing list. > While preparing the CI tests, the patches you submitted couldn't be applied to the current HEAD of the repository. > > ----- Output ----- > > error: patch failed: drivers/bluetooth/btusb.c:2267 > error: drivers/bluetooth/btusb.c: patch does not apply > hint: Use 'git am --show-current-patch' to see the failed patch > > Please resolve the issue and submit the patches again. What tree is this patch for? Also Im surprised the setting of HCI_QUIRK_NO_SUSPEND_NOTIFIER would actually cause what you are describing since in that case register_pm_notifier is not supposed to be called: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git/tree/net/bluetooth/hci_core.c#n2767
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index e7914783d29e..1bb8d0f2e8b8 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -2267,7 +2267,6 @@ static int btusb_setup_csr(struct hci_dev *hdev) set_bit(HCI_QUIRK_BROKEN_STORED_LINK_KEY, &hdev->quirks); set_bit(HCI_QUIRK_BROKEN_ERR_DATA_REPORTING, &hdev->quirks); set_bit(HCI_QUIRK_BROKEN_FILTER_CLEAR_ALL, &hdev->quirks); - set_bit(HCI_QUIRK_NO_SUSPEND_NOTIFIER, &hdev->quirks); /* Clear the reset quirk since this is not an actual * early Bluetooth 1.1 device from CSR.
It seems that setting the bit HCI_QUICK_NO_SUSPEND_NOTIFIER on some fake CSR 5.0 clones can them to get registered 2 times causing a kernel panic. After not setting the bit HCI_QUICK_NO_SUSPEND_NOTIFIER everything works fine and no kernel panic can be observed. Signed-off-by: Mihir Khatri <MihirKhatri@proton.me> ---