[0/7] ceph: various mdsc and cap handling cleanups for v5.2

Message

Jeffrey Layton April 25, 2019, 3:28 p.m. UTC

I had posted several of these patches a few weeks ago as part of another
set, and Zheng suggested we not merge a few of them until we are farther
along with the async dirop work.

This set is the remaining patches, plus a few others that I'd like to
see go into v5.2. They should introduce no behavioral changes on their
own, but pave the way for asynchronous MDS requests later, and clean
up the code with an aim toward eliminating some subtle assumptions that
could lead to bugs later.

Jeff Layton (7):
  ceph: use pathlen values returned by set_request_path_attr
  ceph: after an MDS request, do callback and completions
  ceph: have ceph_mdsc_do_request call ceph_mdsc_submit_request
  ceph: move wait for mds request into helper function
  ceph: fix comment over ceph_drop_caps_for_unlink
  ceph: simplify arguments and return semantics of try_get_cap_refs
  ceph: just call get_session in __ceph_lookup_mds_session

 fs/ceph/caps.c       | 78 ++++++++++++++++++--------------------------
 fs/ceph/mds_client.c | 67 +++++++++++++++++++------------------
 fs/ceph/mds_client.h |  5 +--
 3 files changed, 67 insertions(+), 83 deletions(-)

Comments

Yan, Zheng April 26, 2019, 5:22 p.m. UTC | #1

On Thu, Apr 25, 2019 at 11:49 PM Jeff Layton <[e-mail]> wrote:
>
> I had posted several of these patches a few weeks ago as part of another
> set, and Zheng suggested we not merge a few of them until we are farther
> along with the async dirop work.
>
> This set is the remaining patches, plus a few others that I'd like to
> see go into v5.2. They should introduce no behavioral changes on their
> own, but pave the way for asynchronous MDS requests later, and clean
> up the code with an aim toward eliminating some subtle assumptions that
> could lead to bugs later.
>
> Jeff Layton (7):
>   ceph: use pathlen values returned by set_request_path_attr
>   ceph: after an MDS request, do callback and completions
>   ceph: have ceph_mdsc_do_request call ceph_mdsc_submit_request
>   ceph: move wait for mds request into helper function
>   ceph: fix comment over ceph_drop_caps_for_unlink
>   ceph: simplify arguments and return semantics of try_get_cap_refs
>   ceph: just call get_session in __ceph_lookup_mds_session
>
>  fs/ceph/caps.c       | 78 ++++++++++++++++++--------------------------
>  fs/ceph/mds_client.c | 67 +++++++++++++++++++------------------
>  fs/ceph/mds_client.h |  5 +--
>  3 files changed, 67 insertions(+), 83 deletions(-)
>


Reviewed-by: "Yan, Zheng" <[e-mail]>


> --
> 2.20.1
>