mbox series

[0/4] ceph: add IO size metric support

Message ID 20210322122852.322927-1-xiubli@redhat.com (mailing list archive)
Headers show
Series ceph: add IO size metric support | expand

Message

Xiubo Li March 22, 2021, 12:28 p.m. UTC
From: Xiubo Li <xiubli@redhat.com>

Currently it will show as the following:

item          total       avg_sz(bytes)   min_sz(bytes)   max_sz(bytes)  total_sz(bytes)
----------------------------------------------------------------------------------------
read          1           10240           10240           10240           10240
write         1           10240           10240           10240           10240



Xiubo Li (4):
  ceph: rename the metric helpers
  ceph: update the __update_latency helper
  ceph: avoid count the same request twice or more
  ceph: add IO size metrics support

 fs/ceph/addr.c       |  20 +++----
 fs/ceph/debugfs.c    |  49 +++++++++++++----
 fs/ceph/file.c       |  47 ++++++++--------
 fs/ceph/mds_client.c |   2 +-
 fs/ceph/metric.c     | 126 ++++++++++++++++++++++++++++++++-----------
 fs/ceph/metric.h     |  22 +++++---
 6 files changed, 184 insertions(+), 82 deletions(-)

Comments

Jeffrey Layton March 24, 2021, 3:06 p.m. UTC | #1
On Mon, 2021-03-22 at 20:28 +0800, xiubli@redhat.com wrote:
> From: Xiubo Li <xiubli@redhat.com>
> 
> Currently it will show as the following:
> 
> item          total       avg_sz(bytes)   min_sz(bytes)   max_sz(bytes)  total_sz(bytes)
> ----------------------------------------------------------------------------------------
> read          1           10240           10240           10240           10240
> write         1           10240           10240           10240           10240
> 
> 
> 
> Xiubo Li (4):
>   ceph: rename the metric helpers
>   ceph: update the __update_latency helper
>   ceph: avoid count the same request twice or more
>   ceph: add IO size metrics support
> 
>  fs/ceph/addr.c       |  20 +++----
>  fs/ceph/debugfs.c    |  49 +++++++++++++----
>  fs/ceph/file.c       |  47 ++++++++--------
>  fs/ceph/mds_client.c |   2 +-
>  fs/ceph/metric.c     | 126 ++++++++++++++++++++++++++++++++-----------
>  fs/ceph/metric.h     |  22 +++++---
>  6 files changed, 184 insertions(+), 82 deletions(-)
> 

I've gone ahead and merged patches 1 and 3 from this series into
ceph-client/testing. 1 was just a trivial renaming that we might as well
get out of the way, and 3 looked like a (minor) bugfix. The other two
still need a bit of work (but nothing major).

Cheers,
Xiubo Li March 25, 2021, 12:42 a.m. UTC | #2
On 2021/3/24 23:06, Jeff Layton wrote:
> On Mon, 2021-03-22 at 20:28 +0800, xiubli@redhat.com wrote:
>> From: Xiubo Li <xiubli@redhat.com>
>>
>> Currently it will show as the following:
>>
>> item          total       avg_sz(bytes)   min_sz(bytes)   max_sz(bytes)  total_sz(bytes)
>> ----------------------------------------------------------------------------------------
>> read          1           10240           10240           10240           10240
>> write         1           10240           10240           10240           10240
>>
>>
>>
>> Xiubo Li (4):
>>    ceph: rename the metric helpers
>>    ceph: update the __update_latency helper
>>    ceph: avoid count the same request twice or more
>>    ceph: add IO size metrics support
>>
>>   fs/ceph/addr.c       |  20 +++----
>>   fs/ceph/debugfs.c    |  49 +++++++++++++----
>>   fs/ceph/file.c       |  47 ++++++++--------
>>   fs/ceph/mds_client.c |   2 +-
>>   fs/ceph/metric.c     | 126 ++++++++++++++++++++++++++++++++-----------
>>   fs/ceph/metric.h     |  22 +++++---
>>   6 files changed, 184 insertions(+), 82 deletions(-)
>>
> I've gone ahead and merged patches 1 and 3 from this series into
> ceph-client/testing. 1 was just a trivial renaming that we might as well
> get out of the way, and 3 looked like a (minor) bugfix. The other two
> still need a bit of work (but nothing major).

Sure, will fix them and post the v2 later.

Thanks Jeff.


> Cheers,