From patchwork Sun Oct 17 18:48:30 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julia Lawall X-Patchwork-Id: 260461 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id o9HIhD4F032568 for ; Sun, 17 Oct 2010 18:43:13 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932583Ab0JQSm3 (ORCPT ); Sun, 17 Oct 2010 14:42:29 -0400 Received: from mgw2.diku.dk ([130.225.96.92]:50835 "EHLO mgw2.diku.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932524Ab0JQSmM (ORCPT ); Sun, 17 Oct 2010 14:42:12 -0400 Received: from localhost (localhost [127.0.0.1]) by mgw2.diku.dk (Postfix) with ESMTP id 72B1319BC0C; Sun, 17 Oct 2010 20:42:11 +0200 (CEST) Received: from mgw2.diku.dk ([127.0.0.1]) by localhost (mgw2.diku.dk [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 16045-02; Sun, 17 Oct 2010 20:42:10 +0200 (CEST) Received: from palace.topps.diku.dk (palace.ekstranet.diku.dk [192.38.115.202]) by mgw2.diku.dk (Postfix) with ESMTP id 4412019BC0F; Sun, 17 Oct 2010 20:42:09 +0200 (CEST) From: Julia Lawall To: Sage Weil Cc: kernel-janitors@vger.kernel.org, ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] fs/ceph/xattr.c: Use kasprintf Date: Sun, 17 Oct 2010 20:48:30 +0200 Message-Id: <1287341311-11161-3-git-send-email-julia@diku.dk> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1287341311-11161-1-git-send-email-julia@diku.dk> References: <1287341311-11161-1-git-send-email-julia@diku.dk> Sender: ceph-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter1.kernel.org [140.211.167.41]); Sun, 17 Oct 2010 18:43:13 +0000 (UTC) diff --git a/fs/ceph/xattr.c b/fs/ceph/xattr.c index 70e9199..b8dd1f0 100644 --- a/fs/ceph/xattr.c +++ b/fs/ceph/xattr.c @@ -716,10 +716,9 @@ int ceph_setxattr(struct dentry *dentry, const char *name, /* preallocate memory for xattr name, value, index node */ err = -ENOMEM; - newname = kmalloc(name_len + 1, GFP_NOFS); + newname = kasprintf(GFP_NOFS, "%s", name); if (!newname) goto out; - memcpy(newname, name, name_len + 1); if (val_len) { newval = kmalloc(val_len + 1, GFP_NOFS);