| Message ID | 1342334726-28541-1-git-send-email-jjzhang@suse.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 07/15/2012 01:45 AM, Jiaju Zhang wrote: > This is a trivial fix for the debug output, as it is inconsistent > with the function name so may confuse people when debugging. > > Signed-off-by: Jiaju Zhang <jjzhang@suse.de> I have been converting these to use __func__ whenever I touch code nearby. Mind if I do that here as well? Reviewed-by: Alex Elder <elder@inktank.com> > --- > net/ceph/osd_client.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c > index 1ffebed..ad6d745 100644 > --- a/net/ceph/osd_client.c > +++ b/net/ceph/osd_client.c > @@ -688,7 +688,7 @@ static void __remove_osd(struct ceph_osd_client *osdc, struct ceph_osd *osd) > > static void remove_all_osds(struct ceph_osd_client *osdc) > { > - dout("__remove_old_osds %p\n", osdc); > + dout("__remove_all_osds %p\n", osdc); dout("%s %p\n", __func__, osdc); > mutex_lock(&osdc->request_mutex); > while (!RB_EMPTY_ROOT(&osdc->osds)) { > struct ceph_osd *osd = rb_entry(rb_first(&osdc->osds), > -- > To unsubscribe from this list: send the line "unsubscribe ceph-devel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 2012-07-16 at 07:55 -0500, Alex Elder wrote: > On 07/15/2012 01:45 AM, Jiaju Zhang wrote: > > This is a trivial fix for the debug output, as it is inconsistent > > with the function name so may confuse people when debugging. > > > > Signed-off-by: Jiaju Zhang <jjzhang@suse.de> > > I have been converting these to use __func__ whenever I touch > code nearby. Mind if I do that here as well? > > Reviewed-by: Alex Elder <elder@inktank.com> Oh, please do;) Using __func__ would be good. Thanks for the review. Thanks, Jiaju > > > --- > > net/ceph/osd_client.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c > > index 1ffebed..ad6d745 100644 > > --- a/net/ceph/osd_client.c > > +++ b/net/ceph/osd_client.c > > @@ -688,7 +688,7 @@ static void __remove_osd(struct ceph_osd_client *osdc, struct ceph_osd *osd) > > > > static void remove_all_osds(struct ceph_osd_client *osdc) > > { > > - dout("__remove_old_osds %p\n", osdc); > > + dout("__remove_all_osds %p\n", osdc); > > dout("%s %p\n", __func__, osdc); > > > mutex_lock(&osdc->request_mutex); > > while (!RB_EMPTY_ROOT(&osdc->osds)) { > > struct ceph_osd *osd = rb_entry(rb_first(&osdc->osds), > > -- > > To unsubscribe from this list: send the line "unsubscribe ceph-devel" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > > -- > To unsubscribe from this list: send the line "unsubscribe ceph-devel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c index 1ffebed..ad6d745 100644 --- a/net/ceph/osd_client.c +++ b/net/ceph/osd_client.c @@ -688,7 +688,7 @@ static void __remove_osd(struct ceph_osd_client *osdc, struct ceph_osd *osd) static void remove_all_osds(struct ceph_osd_client *osdc) { - dout("__remove_old_osds %p\n", osdc); + dout("__remove_all_osds %p\n", osdc); mutex_lock(&osdc->request_mutex); while (!RB_EMPTY_ROOT(&osdc->osds)) { struct ceph_osd *osd = rb_entry(rb_first(&osdc->osds),
This is a trivial fix for the debug output, as it is inconsistent with the function name so may confuse people when debugging. Signed-off-by: Jiaju Zhang <jjzhang@suse.de> --- net/ceph/osd_client.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html