diff mbox

[1/8] libceph: be less chatty about stray replies

Message ID 1343663971-3221-2-git-send-email-sage@inktank.com (mailing list archive)
State New, archived
Headers show

Commit Message

Sage Weil July 30, 2012, 3:59 p.m. UTC
There are many (normal) conditions that can lead to us getting
unexpected replies, include cluster topology changes, osd failures,
and timeouts.  There's no need to spam the console about it.

Signed-off-by: Sage Weil <sage@inktank.com>
---
 net/ceph/osd_client.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Alex Elder July 30, 2012, 11 p.m. UTC | #1
On 07/30/2012 10:59 AM, Sage Weil wrote:
> There are many (normal) conditions that can lead to us getting
> unexpected replies, include cluster topology changes, osd failures,
> and timeouts.  There's no need to spam the console about it.
> 
> Signed-off-by: Sage Weil <sage@inktank.com>

Looks good.

Reviewed-by: Alex Elder <elder@inktank.com>

> ---
>  net/ceph/osd_client.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c
> index ad427e6..42119c0 100644
> --- a/net/ceph/osd_client.c
> +++ b/net/ceph/osd_client.c
> @@ -2037,8 +2037,8 @@ static struct ceph_msg *get_reply(struct ceph_connection *con,
>  	if (!req) {
>  		*skip = 1;
>  		m = NULL;
> -		pr_info("get_reply unknown tid %llu from osd%d\n", tid,
> -			osd->o_osd);
> +		dout("get_reply unknown tid %llu from osd%d\n", tid,
> +		     osd->o_osd);
>  		goto out;
>  	}
>  
> 

--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c
index ad427e6..42119c0 100644
--- a/net/ceph/osd_client.c
+++ b/net/ceph/osd_client.c
@@ -2037,8 +2037,8 @@  static struct ceph_msg *get_reply(struct ceph_connection *con,
 	if (!req) {
 		*skip = 1;
 		m = NULL;
-		pr_info("get_reply unknown tid %llu from osd%d\n", tid,
-			osd->o_osd);
+		dout("get_reply unknown tid %llu from osd%d\n", tid,
+		     osd->o_osd);
 		goto out;
 	}