From patchwork Thu Aug 23 12:14:29 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Iulius Curt X-Patchwork-Id: 1366821 Return-Path: X-Original-To: patchwork-ceph-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id E83F8DF2AB for ; Thu, 23 Aug 2012 12:14:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932955Ab2HWMOH (ORCPT ); Thu, 23 Aug 2012 08:14:07 -0400 Received: from mail-qa0-f46.google.com ([209.85.216.46]:59090 "EHLO mail-qa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932930Ab2HWMOF (ORCPT ); Thu, 23 Aug 2012 08:14:05 -0400 Received: by qaas11 with SMTP id s11so538820qaa.19 for ; Thu, 23 Aug 2012 05:14:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=b8QkFkhyVYumSBZpyhZHyMQn7ZURNlx9sk+bIJ0qDhY=; b=k0cfysRT0T2kdGM66qz+8sC/TviKGMX0wDuvq8K0dhTrZblDXfos3oU9yr5Dh12Kut j1QEtcVZrw6siLqfFrEECG14WFQ4M5tF2GUSdiReBeifMIjn771a0FzDnGU/Fjkh2Jow 8rXGvhjSUK5xyyBj8OUckmSTvKCVQMqDdFxoAcE6AV2MEkmlPafRMIbxR+IuFgFIosMj qa5szsOMnDD9Vi0ZX7JEfdNbde+MUsL/KURJUcqwto0L84IThMppyEXXwrbkRHYV7g8R ShFTOtVtTTBwPw989+sPRSbsAA63rS+5Cm0Oi/laCuxmlJXz8uoH1vPl8Bj+q96kRj78 qNaQ== Received: by 10.224.196.73 with SMTP id ef9mr2483294qab.36.1345724043460; Thu, 23 Aug 2012 05:14:03 -0700 (PDT) Received: from icurt.ixiacom.com ([205.168.23.154]) by mx.google.com with ESMTPS id y4sm1583501qan.7.2012.08.23.05.14.01 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 23 Aug 2012 05:14:02 -0700 (PDT) From: Iulius Curt To: sage@inktank.com Cc: davem@davemloft.net, ceph-devel@vger.kernel.org, netdev@vger.kernel.org, dbaluta@ixiacom.com, Iulius Curt , Iulius Curt Subject: [PATCH v2] libceph: Fix sparse warning Date: Thu, 23 Aug 2012 15:14:29 +0300 Message-Id: <1345724069-12405-1-git-send-email-icurt@ixiacom.com> X-Mailer: git-send-email 1.7.9.5 Sender: ceph-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org From: Iulius Curt Make ceph_monc_do_poolop() static to remove the following sparse warning: * net/ceph/mon_client.c:616:5: warning: symbol 'ceph_monc_do_poolop' was not declared. Should it be static? Also drops the 'ceph_monc_' prefix, now being a private function. Signed-off-by: Iulius Curt --- v1 ---> v2 * drop the 'ceph_monc_' prefix --- net/ceph/mon_client.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/ceph/mon_client.c b/net/ceph/mon_client.c index 105d533..84ce495 100644 --- a/net/ceph/mon_client.c +++ b/net/ceph/mon_client.c @@ -613,7 +613,7 @@ bad: /* * Do a synchronous pool op. */ -int ceph_monc_do_poolop(struct ceph_mon_client *monc, u32 op, +static int do_poolop(struct ceph_mon_client *monc, u32 op, u32 pool, u64 snapid, char *buf, int len) { @@ -663,7 +663,7 @@ out: int ceph_monc_create_snapid(struct ceph_mon_client *monc, u32 pool, u64 *snapid) { - return ceph_monc_do_poolop(monc, POOL_OP_CREATE_UNMANAGED_SNAP, + return do_poolop(monc, POOL_OP_CREATE_UNMANAGED_SNAP, pool, 0, (char *)snapid, sizeof(*snapid)); } @@ -672,7 +672,7 @@ EXPORT_SYMBOL(ceph_monc_create_snapid); int ceph_monc_delete_snapid(struct ceph_mon_client *monc, u32 pool, u64 snapid) { - return ceph_monc_do_poolop(monc, POOL_OP_CREATE_UNMANAGED_SNAP, + return do_poolop(monc, POOL_OP_CREATE_UNMANAGED_SNAP, pool, snapid, 0, 0); }