| Message ID | 1360266123-28972-6-git-send-email-danny.al-gaaf@bisect.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
diff --git a/src/common/AsyncReserver.h b/src/common/AsyncReserver.h index 8cc2258..638bfb3 100644 --- a/src/common/AsyncReserver.h +++ b/src/common/AsyncReserver.h @@ -37,7 +37,7 @@ class AsyncReserver { void do_queues() { while (in_progress.size() < max_allowed && - queue.size()) { + !queue.empty()) { pair<T, Context*> p = queue.front(); queue_pointers.erase(p.first); queue.pop_front();
Fix warning for usage of queue.size() in do_queues(). Use empty() since it should be prefered as it has, following the standard, a constant time complexity regardless of the containter type. The same is not guaranteed for size(). warning from cppchecker was: [common/AsyncReserver.h:40]: (performance) Possible inefficient checking for 'queue' emptiness. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de> --- src/common/AsyncReserver.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)