From patchwork Sun Mar 17 14:51:41 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yan, Zheng" X-Patchwork-Id: 2283991 Return-Path: X-Original-To: patchwork-ceph-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 5C9A0E00E5 for ; Sun, 17 Mar 2013 15:06:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932758Ab3CQOyL (ORCPT ); Sun, 17 Mar 2013 10:54:11 -0400 Received: from mga03.intel.com ([143.182.124.21]:30053 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932755Ab3CQOyK (ORCPT ); Sun, 17 Mar 2013 10:54:10 -0400 Received: from azsmga002.ch.intel.com ([10.2.17.35]) by azsmga101.ch.intel.com with ESMTP; 17 Mar 2013 07:54:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.84,859,1355126400"; d="scan'208";a="215704587" Received: from unknown (HELO zyan5-mobl.ccr.corp.intel.com) ([10.255.20.118]) by AZSMGA002.ch.intel.com with ESMTP; 17 Mar 2013 07:54:06 -0700 From: "Yan, Zheng" To: ceph-devel@vger.kernel.org Cc: sage@inktank.com, greg@inktank.com, "Yan, Zheng" Subject: [PATCH 38/39] mds: don't replicate purging dentry Date: Sun, 17 Mar 2013 22:51:41 +0800 Message-Id: <1363531902-24909-39-git-send-email-zheng.z.yan@intel.com> X-Mailer: git-send-email 1.7.11.7 In-Reply-To: <1363531902-24909-1-git-send-email-zheng.z.yan@intel.com> References: <1363531902-24909-1-git-send-email-zheng.z.yan@intel.com> Sender: ceph-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org From: "Yan, Zheng" open_remote_ino is racy, it's possible someone deletes the inode's last linkage while the MDS is discovering the inode. Signed-off-by: Yan, Zheng Reviewed-by: Greg Farnum --- src/mds/MDCache.cc | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/mds/MDCache.cc b/src/mds/MDCache.cc index 24f1109..d730ff1 100644 --- a/src/mds/MDCache.cc +++ b/src/mds/MDCache.cc @@ -9225,8 +9225,15 @@ void MDCache::handle_discover(MDiscover *dis) if (dis->get_want_ino()) { // lookup by ino CInode *in = get_inode(dis->get_want_ino(), snapid); - if (in && in->is_auth() && in->get_parent_dn()->get_dir() == curdir) + if (in && in->is_auth() && in->get_parent_dn()->get_dir() == curdir) { dn = in->get_parent_dn(); + if (dn->state_test(CDentry::STATE_PURGING)) { + // set error flag in reply + dout(7) << "dentry " << *dn << " is purging, flagging error ino" << dendl; + reply->set_flag_error_ino(); + break; + } + } } else if (dis->get_want().depth() > 0) { // lookup dentry dn = curdir->lookup(dis->get_dentry(i), snapid);