| Message ID | 1377735546-8732-1-git-send-email-sage@inktank.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 08/28/2013 07:19 PM, Sage Weil wrote: > Fix a typo that used the wrong bitmask for the pg.seed calculation. This > is normally unnoticed because in most cases pg_num == pgp_num. It is, however, > a bug that is easily corrected. Looks good to me. The other two uses of pgp_num_mask are coupled with pgp_num (not pg_num) in a ceph_stable_mod() call. Reviewed-by: Alex Elder <elder@linaro.org> > CC: stable@vger.kernel.org > Signed-off-by: Sage Weil <sage@inktank.com> > --- > net/ceph/osdmap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/ceph/osdmap.c b/net/ceph/osdmap.c > index 603ddd9..dbd9a47 100644 > --- a/net/ceph/osdmap.c > +++ b/net/ceph/osdmap.c > @@ -1129,7 +1129,7 @@ static int *calc_pg_raw(struct ceph_osdmap *osdmap, struct ceph_pg pgid, > > /* pg_temp? */ > pgid.seed = ceph_stable_mod(pgid.seed, pool->pg_num, > - pool->pgp_num_mask); > + pool->pg_num_mask); > pg = __lookup_pg_mapping(&osdmap->pg_temp, pgid); > if (pg) { > *num = pg->len; > -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/ceph/osdmap.c b/net/ceph/osdmap.c index 603ddd9..dbd9a47 100644 --- a/net/ceph/osdmap.c +++ b/net/ceph/osdmap.c @@ -1129,7 +1129,7 @@ static int *calc_pg_raw(struct ceph_osdmap *osdmap, struct ceph_pg pgid, /* pg_temp? */ pgid.seed = ceph_stable_mod(pgid.seed, pool->pg_num, - pool->pgp_num_mask); + pool->pg_num_mask); pg = __lookup_pg_mapping(&osdmap->pg_temp, pgid); if (pg) { *num = pg->len;
Fix a typo that used the wrong bitmask for the pg.seed calculation. This is normally unnoticed because in most cases pg_num == pgp_num. It is, however, a bug that is easily corrected. CC: stable@vger.kernel.org Signed-off-by: Sage Weil <sage@inktank.com> --- net/ceph/osdmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)