| Message ID | 1392355784-10422-2-git-send-email-lucienchao@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 02/13/2014 11:29 PM, Guangliang Zhao wrote: > Signed-off-by: Guangliang Zhao <lucienchao@gmail.com> Looks good. Is there a reason we can't just call forget_all_cached_acls(inode) directly? Or is it just so that we have our own complete private ACL interface? (I have no problem with it, just asking.) Reviewed-by: Alex Elder <elder@linaro.org> > --- > fs/ceph/acl.c | 5 ----- > fs/ceph/super.h | 6 +++++- > 2 files changed, 5 insertions(+), 6 deletions(-) > > diff --git a/fs/ceph/acl.c b/fs/ceph/acl.c > index 64fddbc..48af0b3 100644 > --- a/fs/ceph/acl.c > +++ b/fs/ceph/acl.c > @@ -54,11 +54,6 @@ static inline struct posix_acl *ceph_get_cached_acl(struct inode *inode, > return acl; > } > > -void ceph_forget_all_cached_acls(struct inode *inode) > -{ > - forget_all_cached_acls(inode); > -} > - > struct posix_acl *ceph_get_acl(struct inode *inode, int type) > { > int size; > diff --git a/fs/ceph/super.h b/fs/ceph/super.h > index c299f7d..8851dc2 100644 > --- a/fs/ceph/super.h > +++ b/fs/ceph/super.h > @@ -13,6 +13,7 @@ > #include <linux/wait.h> > #include <linux/writeback.h> > #include <linux/slab.h> > +#include <linux/posix_acl.h> > > #include <linux/ceph/libceph.h> > > @@ -745,7 +746,10 @@ extern const struct xattr_handler *ceph_xattr_handlers[]; > struct posix_acl *ceph_get_acl(struct inode *, int); > int ceph_init_acl(struct dentry *, struct inode *, struct inode *); > int ceph_acl_chmod(struct dentry *, struct inode *); > -void ceph_forget_all_cached_acls(struct inode *inode); > +static inline void ceph_forget_all_cached_acls(struct inode *inode) > +{ > + forget_all_cached_acls(inode); > +} > > #else > > -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Applied. On Fri, 14 Feb 2014, Alex Elder wrote: > On 02/13/2014 11:29 PM, Guangliang Zhao wrote: > > Signed-off-by: Guangliang Zhao <lucienchao@gmail.com> > > Looks good. Is there a reason we can't just call > forget_all_cached_acls(inode) directly? Or is it > just so that we have our own complete private ACL > interface? (I have no problem with it, just asking.) > > Reviewed-by: Alex Elder <elder@linaro.org> > > > --- > > fs/ceph/acl.c | 5 ----- > > fs/ceph/super.h | 6 +++++- > > 2 files changed, 5 insertions(+), 6 deletions(-) > > > > diff --git a/fs/ceph/acl.c b/fs/ceph/acl.c > > index 64fddbc..48af0b3 100644 > > --- a/fs/ceph/acl.c > > +++ b/fs/ceph/acl.c > > @@ -54,11 +54,6 @@ static inline struct posix_acl *ceph_get_cached_acl(struct inode *inode, > > return acl; > > } > > > > -void ceph_forget_all_cached_acls(struct inode *inode) > > -{ > > - forget_all_cached_acls(inode); > > -} > > - > > struct posix_acl *ceph_get_acl(struct inode *inode, int type) > > { > > int size; > > diff --git a/fs/ceph/super.h b/fs/ceph/super.h > > index c299f7d..8851dc2 100644 > > --- a/fs/ceph/super.h > > +++ b/fs/ceph/super.h > > @@ -13,6 +13,7 @@ > > #include <linux/wait.h> > > #include <linux/writeback.h> > > #include <linux/slab.h> > > +#include <linux/posix_acl.h> > > > > #include <linux/ceph/libceph.h> > > > > @@ -745,7 +746,10 @@ extern const struct xattr_handler *ceph_xattr_handlers[]; > > struct posix_acl *ceph_get_acl(struct inode *, int); > > int ceph_init_acl(struct dentry *, struct inode *, struct inode *); > > int ceph_acl_chmod(struct dentry *, struct inode *); > > -void ceph_forget_all_cached_acls(struct inode *inode); > > +static inline void ceph_forget_all_cached_acls(struct inode *inode) > > +{ > > + forget_all_cached_acls(inode); > > +} > > > > #else > > > > > > -- > To unsubscribe from this list: send the line "unsubscribe ceph-devel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/ceph/acl.c b/fs/ceph/acl.c index 64fddbc..48af0b3 100644 --- a/fs/ceph/acl.c +++ b/fs/ceph/acl.c @@ -54,11 +54,6 @@ static inline struct posix_acl *ceph_get_cached_acl(struct inode *inode, return acl; } -void ceph_forget_all_cached_acls(struct inode *inode) -{ - forget_all_cached_acls(inode); -} - struct posix_acl *ceph_get_acl(struct inode *inode, int type) { int size; diff --git a/fs/ceph/super.h b/fs/ceph/super.h index c299f7d..8851dc2 100644 --- a/fs/ceph/super.h +++ b/fs/ceph/super.h @@ -13,6 +13,7 @@ #include <linux/wait.h> #include <linux/writeback.h> #include <linux/slab.h> +#include <linux/posix_acl.h> #include <linux/ceph/libceph.h> @@ -745,7 +746,10 @@ extern const struct xattr_handler *ceph_xattr_handlers[]; struct posix_acl *ceph_get_acl(struct inode *, int); int ceph_init_acl(struct dentry *, struct inode *, struct inode *); int ceph_acl_chmod(struct dentry *, struct inode *); -void ceph_forget_all_cached_acls(struct inode *inode); +static inline void ceph_forget_all_cached_acls(struct inode *inode) +{ + forget_all_cached_acls(inode); +} #else
Signed-off-by: Guangliang Zhao <lucienchao@gmail.com> --- fs/ceph/acl.c | 5 ----- fs/ceph/super.h | 6 +++++- 2 files changed, 5 insertions(+), 6 deletions(-)