From patchwork Wed Oct 8 20:27:27 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabian Frederick X-Patchwork-Id: 5055611 Return-Path: X-Original-To: patchwork-ceph-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id A57F6C11AB for ; Wed, 8 Oct 2014 20:27:47 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id EAFC0201BC for ; Wed, 8 Oct 2014 20:27:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 26D8E20107 for ; Wed, 8 Oct 2014 20:27:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754566AbaJHU1a (ORCPT ); Wed, 8 Oct 2014 16:27:30 -0400 Received: from mailrelay010.isp.belgacom.be ([195.238.6.177]:50380 "EHLO mailrelay010.isp.belgacom.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754515AbaJHU1a (ORCPT ); Wed, 8 Oct 2014 16:27:30 -0400 X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApkSAPCcNVRbsGtC/2dsb2JhbABfgw65BwUBc5oCBAKBCxcBe4QxLyOBGjeIQgG3NY5qhiCKJB2ENQWdRZYNg2U7L4JKAQEB Received: from 66.107-176-91.adsl-dyn.isp.belgacom.be (HELO localhost.localdomain) ([91.176.107.66]) by relay.skynet.be with ESMTP; 08 Oct 2014 22:27:27 +0200 From: Fabian Frederick To: linux-kernel@vger.kernel.org Cc: Fabian Frederick , Sage Weil , ceph-devel@vger.kernel.org Subject: [PATCH 1/1 linux-next] ceph: return error code directly. Date: Wed, 8 Oct 2014 22:27:27 +0200 Message-Id: <1412800047-19818-1-git-send-email-fabf@skynet.be> X-Mailer: git-send-email 1.9.1 Sender: ceph-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Testing err before returning value is not needed. Signed-off-by: Fabian Frederick --- fs/ceph/ioctl.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/fs/ceph/ioctl.c b/fs/ceph/ioctl.c index a822a6e..b2d777a 100644 --- a/fs/ceph/ioctl.c +++ b/fs/ceph/ioctl.c @@ -54,10 +54,7 @@ static long __validate_layout(struct ceph_mds_client *mdsc, break; } mutex_unlock(&mdsc->mutex); - if (err) - return err; - - return 0; + return err; } static long ceph_ioctl_set_layout(struct file *file, void __user *arg)