Message ID | 1415208804-10163-3-git-send-email-idryomov@redhat.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c index ce09da2cf32b..2a42c795b1ac 100644 --- a/net/ceph/osd_client.c +++ b/net/ceph/osd_client.c @@ -1254,6 +1254,8 @@ static void __unregister_linger_request(struct ceph_osd_client *osdc, if (list_empty(&req->r_osd_item)) req->r_osd = NULL; } + + list_del_init(&req->r_req_lru_item); /* can be on notarget */ ceph_osdc_put_request(req); }
kick_requests() can put linger requests on the notarget list. This means we need to clear the much-overloaded req->r_req_lru_item in __unregister_linger_request() as well, or we get an assertion failure in ceph_osdc_release_request() - !list_empty(&req->r_req_lru_item). AFAICT the assumption was that registered linger requests cannot be on any of req->r_req_lru_item lists, but that's clearly not the case. Signed-off-by: Ilya Dryomov <idryomov@redhat.com> --- net/ceph/osd_client.c | 2 ++ 1 file changed, 2 insertions(+)