diff mbox

libceph: use kvfree() in ceph_put_page_vector()

Message ID 1433169361-18667-1-git-send-email-geliangtang@163.com (mailing list archive)
State New, archived
Headers show

Commit Message

Geliang Tang June 1, 2015, 2:36 p.m. UTC 
Use kvfree() instead of open-coding it.

Signed-off-by: Geliang Tang <geliangtang@163.com>
---
 net/ceph/pagevec.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Ilya Dryomov June 1, 2015, 3:03 p.m. UTC | #1 
On Mon, Jun 1, 2015 at 5:36 PM, Geliang Tang <geliangtang@163.com> wrote:
> Use kvfree() instead of open-coding it.
>
> Signed-off-by: Geliang Tang <geliangtang@163.com>
> ---
>  net/ceph/pagevec.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/net/ceph/pagevec.c b/net/ceph/pagevec.c
> index 096d914..d4f5f22 100644
> --- a/net/ceph/pagevec.c
> +++ b/net/ceph/pagevec.c
> @@ -51,10 +51,7 @@ void ceph_put_page_vector(struct page **pages, int num_pages, bool dirty)
>                         set_page_dirty_lock(pages[i]);
>                 put_page(pages[i]);
>         }
> -       if (is_vmalloc_addr(pages))
> -               vfree(pages);
> -       else
> -               kfree(pages);
> +       kvfree(pages);
>  }
>  EXPORT_SYMBOL(ceph_put_page_vector);

Already fixed in testing, wasn't pushed to linux-next though, sorry!

Thanks,

                Ilya
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/net/ceph/pagevec.c b/net/ceph/pagevec.c
index 096d914..d4f5f22 100644
--- a/net/ceph/pagevec.c
+++ b/net/ceph/pagevec.c
@@ -51,10 +51,7 @@  void ceph_put_page_vector(struct page **pages, int num_pages, bool dirty)
 			set_page_dirty_lock(pages[i]);
 		put_page(pages[i]);
 	}
-	if (is_vmalloc_addr(pages))
-		vfree(pages);
-	else
-		kfree(pages);
+	kvfree(pages);
 }
 EXPORT_SYMBOL(ceph_put_page_vector);