diff mbox

ceph: initialize pathbase in the !dentry case in encode_caps_cb()

Message ID 1470753815-5848-1-git-send-email-idryomov@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Ilya Dryomov Aug. 9, 2016, 2:43 p.m. UTC
pathbase is the base inode; set it to 0 if we've got no path.

Coverity-id: 146348
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
---
 fs/ceph/mds_client.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Alex Elder Aug. 9, 2016, 2:48 p.m. UTC | #1
On 08/09/2016 09:43 AM, Ilya Dryomov wrote:
> pathbase is the base inode; set it to 0 if we've got no path.
> 
> Coverity-id: 146348
> Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

I'm surprised the compiler didn't complain about this.

Reviewed-by: Alex Elder <elder@linaro.org>

> ---
>  fs/ceph/mds_client.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c
> index fa59a85226b2..f72d4ae303b2 100644
> --- a/fs/ceph/mds_client.c
> +++ b/fs/ceph/mds_client.c
> @@ -2759,6 +2759,7 @@ static int encode_caps_cb(struct inode *inode, struct ceph_cap *cap,
>  	} else {
>  		path = NULL;
>  		pathlen = 0;
> +		pathbase = 0;
>  	}
>  
>  	spin_lock(&ci->i_ceph_lock);
> 

--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c
index fa59a85226b2..f72d4ae303b2 100644
--- a/fs/ceph/mds_client.c
+++ b/fs/ceph/mds_client.c
@@ -2759,6 +2759,7 @@  static int encode_caps_cb(struct inode *inode, struct ceph_cap *cap,
 	} else {
 		path = NULL;
 		pathlen = 0;
+		pathbase = 0;
 	}
 
 	spin_lock(&ci->i_ceph_lock);