From patchwork Fri Jan 26 06:54:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chengguang Xu X-Patchwork-Id: 10185227 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9B70560383 for ; Fri, 26 Jan 2018 07:55:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8E9D628599 for ; Fri, 26 Jan 2018 07:55:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 81DD1285C9; Fri, 26 Jan 2018 07:55:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 12F8A28599 for ; Fri, 26 Jan 2018 07:55:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751999AbeAZHzr (ORCPT ); Fri, 26 Jan 2018 02:55:47 -0500 Received: from mr11p00im-asmtp001.me.com ([17.110.69.252]:29918 "EHLO mr11p00im-asmtp001.me.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751852AbeAZHzq (ORCPT ); Fri, 26 Jan 2018 02:55:46 -0500 X-Greylist: delayed 3600 seconds by postgrey-1.27 at vger.kernel.org; Fri, 26 Jan 2018 02:55:46 EST Received: from process-dkim-sign-daemon.mr11p00im-asmtp001.me.com by mr11p00im-asmtp001.me.com (Oracle Communications Messaging Server 8.0.1.2.20170607 64bit (built Jun 7 2017)) id <0P3500300HTF3Y00@mr11p00im-asmtp001.me.com>; Fri, 26 Jan 2018 06:55:12 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=04042017; t=1516949712; bh=M8UIyBBKwVXEdA1lDbOq0PP56OdQAIay612ON4KiH9g=; h=From:To:Subject:Date:Message-id; b=uaSJ2An1gKgd66jg3bYsH9XmznTPzWShjVCxGAJsT56vc8ukrQEzIyihFYdSLpaDr fLZ1KOuT0C4aGtVxZ3wXjCP9erAXgdE2HARwfl6G06n4mANaiipC3xo6yUgMz49OCl QUNafBsAlULLHt679gzvZxAsEu1nWY4/W+6oec9xWtOldWHSsaVgw/0YirEiBo1vu0 amJiQ3Jo4tHGRdf5js9Jv5iWxFA9UMjf1odQBAi/DjVUON7JA0WfMWr9lQ0ENom6My YothjMQPRIBKe0EzHkOYQFFYlruEBZE/oqT5EZTRNoHZYGmfL4F4+J5TpoXc/vOHdt UcCvESknmhcyg== Received: from icloud.com ([127.0.0.1]) by mr11p00im-asmtp001.me.com (Oracle Communications Messaging Server 8.0.1.2.20170607 64bit (built Jun 7 2017)) with ESMTPSA id <0P3500GG9HVQS410@mr11p00im-asmtp001.me.com>; Fri, 26 Jan 2018 06:55:10 +0000 (GMT) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-01-26_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 clxscore=1011 suspectscore=1 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1801260090 From: Chengguang Xu To: ceph-devel@vger.kernel.org Cc: zyan@redhat.com, sage@redhat.com, davem@davemloft.net, idryomov@gmail.com, netdev@vger.kernel.org, Chengguang Xu Subject: [PATCH] ceph: Check memory allocation result Date: Fri, 26 Jan 2018 14:54:43 +0800 Message-id: <1516949683-127606-1-git-send-email-cgxu519@icloud.com> X-Mailer: git-send-email 1.8.3.1 Sender: ceph-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Should check result of kstrndup() in case of memory allocation failure. Signed-off-by: Chengguang Xu --- net/ceph/ceph_common.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/net/ceph/ceph_common.c b/net/ceph/ceph_common.c index 5c036d2..1e492ef 100644 --- a/net/ceph/ceph_common.c +++ b/net/ceph/ceph_common.c @@ -421,6 +421,10 @@ struct ceph_options * opt->name = kstrndup(argstr[0].from, argstr[0].to-argstr[0].from, GFP_KERNEL); + if (!opt->name) { + err = -ENOMEM; + goto out; + } break; case Opt_secret: opt->key = kzalloc(sizeof(*opt->key), GFP_KERNEL);