From patchwork Sun Dec 23 01:37:56 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fengguang Wu X-Patchwork-Id: 1906681 Return-Path: X-Original-To: patchwork-ceph-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 89A4E3FC64 for ; Sun, 23 Dec 2012 01:38:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752434Ab2LWBh7 (ORCPT ); Sat, 22 Dec 2012 20:37:59 -0500 Received: from mga11.intel.com ([192.55.52.93]:40975 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752406Ab2LWBh7 (ORCPT ); Sat, 22 Dec 2012 20:37:59 -0500 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 22 Dec 2012 17:37:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.84,338,1355126400"; d="diff'?scan'208";a="266049999" Received: from unknown (HELO wfg-t420.sh.intel.com) ([10.255.21.190]) by fmsmga001.fm.intel.com with ESMTP; 22 Dec 2012 17:37:57 -0800 Received: from wfg by wfg-t420.sh.intel.com with local (Exim 4.77) (envelope-from ) id 1TmaVo-0003XR-Pv; Sun, 23 Dec 2012 09:37:56 +0800 Date: Sun, 23 Dec 2012 09:37:56 +0800 From: Fengguang Wu To: Alex Elder Cc: ceph-devel@vger.kernel.org Subject: drivers/block/rbd.c:2170:19: sparse: symbol 'rbd_dev_create' was not declared. Should it be static? Message-ID: <20121223013756.GB11275@localhost> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <50d3c4c4.+GYegH2UzJwRTkBr%yuanhan.liu@linux.intel.com> User-Agent: Heirloom mailx 12.5 6/20/10 Sender: ceph-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org Hi Alex, FYI, there are new sparse warnings show up in tree: git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client.git for-linus head: c3e946ce7276faf0b302acd25c7b874edbeba661 commit: c53d589337e9a211413484a604c76072e8474dc0 rbd: define rbd_dev_{create,destroy}() helpers date: 7 weeks ago drivers/block/rbd.c:1293:42: sparse: Using plain integer as NULL pointer drivers/block/rbd.c:1341:26: sparse: incorrect type in assignment (different base types) drivers/block/rbd.c:1341:26: expected unsigned long long [unsigned] [usertype] ver drivers/block/rbd.c:1341:26: got restricted __le64 [usertype] drivers/block/rbd.c:1351:46: sparse: Using plain integer as NULL pointer drivers/block/rbd.c:1395:26: sparse: incorrect type in assignment (different base types) drivers/block/rbd.c:1395:26: expected unsigned long long [unsigned] [usertype] ver drivers/block/rbd.c:1395:26: got restricted __le64 [usertype] drivers/block/rbd.c:1396:29: sparse: incorrect type in assignment (different base types) drivers/block/rbd.c:1396:29: expected unsigned long long [unsigned] [usertype] cookie drivers/block/rbd.c:1396:29: got restricted __le64 [usertype] drivers/block/rbd.c:1434:29: sparse: incorrect type in assignment (different base types) drivers/block/rbd.c:1434:29: expected unsigned long long [unsigned] [usertype] cookie drivers/block/rbd.c:1434:29: got restricted __le64 [usertype] + drivers/block/rbd.c:2170:19: sparse: symbol 'rbd_dev_create' was not declared. Should it be static? drivers/block/rbd.c:2529:17: sparse: incorrect type in assignment (different base types) drivers/block/rbd.c:2529:17: expected restricted __le64 [usertype] snap_id drivers/block/rbd.c:2529:17: got unsigned long long [unsigned] [long] [long long] drivers/block/rbd.c:2530:46: sparse: incorrect type in argument 2 (different base types) drivers/block/rbd.c:2530:46: expected unsigned long long [unsigned] [usertype] snap_id drivers/block/rbd.c:2530:46: got restricted __le64 [usertype] snap_id drivers/block/rbd.c:2533:50: sparse: incorrect type in argument 2 (different base types) drivers/block/rbd.c:2533:50: expected unsigned long long [unsigned] [usertype] snap_id drivers/block/rbd.c:2533:50: got restricted __le64 [usertype] snap_id drivers/block/rbd.c:1551:32: sparse: context imbalance in 'rbd_rq_fn' - unexpected unlock Please consider folding the attached diff :-) --- 0-DAY kernel build testing backend Open Source Technology Center Fengguang Wu, Yuanhan Liu Intel Corporation diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c index a8ad8f8..077e177 100644 --- a/drivers/block/rbd.c +++ b/drivers/block/rbd.c @@ -2167,7 +2167,7 @@ static void rbd_spec_free(struct kref *kref) kfree(spec); } -struct rbd_device *rbd_dev_create(struct rbd_client *rbdc, +static struct rbd_device *rbd_dev_create(struct rbd_client *rbdc, struct rbd_spec *spec) { struct rbd_device *rbd_dev;