| Message ID | 20130523183636.GA10316@elgon.mountain (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
diff --git a/fs/ceph/ioctl.c b/fs/ceph/ioctl.c index e0b4ef3..98fe5e7 100644 --- a/fs/ceph/ioctl.c +++ b/fs/ceph/ioctl.c @@ -43,7 +43,7 @@ static long __validate_layout(struct ceph_mds_client *mdsc, if ((l->object_size & ~PAGE_MASK) || (l->stripe_unit & ~PAGE_MASK) || (l->stripe_unit != 0 && - ((unsigned)l->object_size % (unsigned)l->stripe_unit))) + (l->object_size % l->stripe_unit))) return -EINVAL; /* make sure it's a valid data pool */
My static checker complains l->stripe_unit could still be zero after we truncate it to 32 bits. I don't see a reason to do the truncation so I have removed it. Both sides are u64 type. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html