diff mbox

ceph: remove the bump of i_version

Message ID 20171030145423.32159-1-jlayton@kernel.org (mailing list archive)
State New, archived
Headers show

Commit Message

Jeffrey Layton Oct. 30, 2017, 2:54 p.m. UTC 
From: Jeff Layton <jlayton@redhat.com>

Eventually, we'll want to wire cephfs up to use the change attribute
that the cluster tracks instead, but for now this is unneeded.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
---
 fs/ceph/inode.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Yan, Zheng Oct. 31, 2017, 7:12 a.m. UTC | #1 
> On 30 Oct 2017, at 22:54, Jeff Layton <jlayton@kernel.org> wrote:
> 
> From: Jeff Layton <jlayton@redhat.com>
> 
> Eventually, we'll want to wire cephfs up to use the change attribute
> that the cluster tracks instead, but for now this is unneeded.
> 
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
> ---
> fs/ceph/inode.c | 1 -
> 1 file changed, 1 deletion(-)
> 
> diff --git a/fs/ceph/inode.c b/fs/ceph/inode.c
> index 373dab5173ca..8aae7200a425 100644
> --- a/fs/ceph/inode.c
> +++ b/fs/ceph/inode.c
> @@ -785,7 +785,6 @@ static int fill_inode(struct inode *inode, struct page *locked_page,
> 
> 	/* update inode */
> 	ci->i_version = le64_to_cpu(info->version);
> -	inode->i_version++;
> 	inode->i_rdev = le32_to_cpu(info->rdev);
> 	inode->i_blkbits = fls(le32_to_cpu(info->layout.fl_stripe_unit)) - 1;
> 

Reviewed-by: "Yan, Zheng" <zyan@redhat.com>
> -- 
> 2.13.6
> 

--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/fs/ceph/inode.c b/fs/ceph/inode.c
index 373dab5173ca..8aae7200a425 100644
--- a/fs/ceph/inode.c
+++ b/fs/ceph/inode.c
@@ -785,7 +785,6 @@  static int fill_inode(struct inode *inode, struct page *locked_page,
 
 	/* update inode */
 	ci->i_version = le64_to_cpu(info->version);
-	inode->i_version++;
 	inode->i_rdev = le32_to_cpu(info->rdev);
 	inode->i_blkbits = fls(le32_to_cpu(info->layout.fl_stripe_unit)) - 1;