From patchwork Sat Jan 27 03:06:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fengguang Wu X-Patchwork-Id: 10187289 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6EACD60383 for ; Sat, 27 Jan 2018 03:07:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6130E2A9DF for ; Sat, 27 Jan 2018 03:07:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 54A7A2AA8D; Sat, 27 Jan 2018 03:07:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 66B7F2AA6E for ; Sat, 27 Jan 2018 03:07:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751452AbeA0DG6 (ORCPT ); Fri, 26 Jan 2018 22:06:58 -0500 Received: from mga02.intel.com ([134.134.136.20]:5773 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751349AbeA0DG5 (ORCPT ); Fri, 26 Jan 2018 22:06:57 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jan 2018 19:06:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,419,1511856000"; d="scan'208";a="25125225" Received: from bee.sh.intel.com (HELO bee) ([10.239.97.14]) by fmsmga004.fm.intel.com with ESMTP; 26 Jan 2018 19:06:56 -0800 Received: from kbuild by bee with local (Exim 4.84_2) (envelope-from ) id 1efGvV-000BBy-VO; Sat, 27 Jan 2018 11:13:09 +0800 Date: Sat, 27 Jan 2018 11:06:40 +0800 From: kbuild test robot To: "Yan, Zheng" Cc: kbuild-all@01.org, ceph-devel@vger.kernel.org, Ilya Dryomov Subject: [PATCH] [DO NOT MERGE] ceph: fix ptr_ret.cocci warnings Message-ID: <20180127030640.GA16408@lkp-g5> References: <201801271138.z5XXxB1x%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <201801271138.z5XXxB1x%fengguang.wu@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: fengguang.wu@intel.com X-SA-Exim-Scanned: No (on bee); SAEximRunCond expanded to false Sender: ceph-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Fengguang Wu fs/ceph/export.c:357:33-39: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Fixes: 961bfcf78c8f ("[DO NOT MERGE] ceph: snapshot nfs re-export") CC: Yan, Zheng Signed-off-by: Fengguang Wu --- export.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/fs/ceph/export.c +++ b/fs/ceph/export.c @@ -354,7 +354,7 @@ static struct dentry *ceph_get_parent(st } out: dout("get_parent %p ino %llx.%llx err=%ld\n", - child, ceph_vinop(inode), (IS_ERR(dn) ? PTR_ERR(dn) : 0)); + child, ceph_vinop(inode), PTR_ERR_OR_ZERO(dn)); return dn; }