| Message ID | 20180531055241.4808-1-cgxu519@gmx.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, May 31, 2018 at 7:52 AM, Chengguang Xu <cgxu519@gmx.com> wrote: > fixes included in this patch: > - add showing mount option 'norequire_active_mds' I think showing norequire_active_mds is pretty useless. Once the filesystem is mounted (i.e. there is a mount entry to look at), it doesn't really matter whether it had to wait for the MDS or not. There is no mount entry to look at at the point where it blocks waiting for the MDS because of norequire_active_mds. Thanks, Ilya -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, May 31, 2018 at 4:58 PM, Ilya Dryomov <idryomov@gmail.com> wrote: > On Thu, May 31, 2018 at 7:52 AM, Chengguang Xu <cgxu519@gmx.com> wrote: >> fixes included in this patch: >> - add showing mount option 'norequire_active_mds' > > I think showing norequire_active_mds is pretty useless. Once the > filesystem is mounted (i.e. there is a mount entry to look at), it > doesn't really matter whether it had to wait for the MDS or not. > I agree with Ilya. showing norequire_active_mds is useless. Regards Yan, Zheng > There is no mount entry to look at at the point where it blocks > waiting for the MDS because of norequire_active_mds. > > Thanks, > > Ilya > -- > To unsubscribe from this list: send the line "unsubscribe ceph-devel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> 在 2018年5月31日，下午10:38，Yan, Zheng <ukernel@gmail.com> 写道： > > On Thu, May 31, 2018 at 4:58 PM, Ilya Dryomov <idryomov@gmail.com> wrote: >> On Thu, May 31, 2018 at 7:52 AM, Chengguang Xu <cgxu519@gmx.com> wrote: >>> fixes included in this patch: >>> - add showing mount option 'norequire_active_mds' >> >> I think showing norequire_active_mds is pretty useless. Once the >> filesystem is mounted (i.e. there is a mount entry to look at), it >> doesn't really matter whether it had to wait for the MDS or not. >> > > I agree with Ilya. showing norequire_active_mds is useless. Okay，that makes sense. Let’s just keep option ‘ino32' then. Thanks, Chengguang. -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/ceph/super.c b/fs/ceph/super.c index b33082e6878f..2ebd14acf56a 100644 --- a/fs/ceph/super.c +++ b/fs/ceph/super.c @@ -541,6 +541,10 @@ static int ceph_show_options(struct seq_file *m, struct dentry *root) seq_puts(m, ",nopoolperm"); if (fsopt->flags & CEPH_MOUNT_OPT_NOQUOTADF) seq_puts(m, ",noquotadf"); + if (fsopt->flags & CEPH_MOUNT_OPT_MOUNTWAIT) + seq_puts(m, ",norequire_active_mds"); + if (fsopt->flags & CEPH_MOUNT_OPT_INO32) + seq_puts(m, ",ino32"); #ifdef CONFIG_CEPH_FS_POSIX_ACL if (fsopt->sb_flags & SB_POSIXACL)
fixes included in this patch: - add showing mount option 'norequire_active_mds' - add showing mount option 'ino32' Signed-off-by: Chengguang Xu <cgxu519@gmx.com> --- v1->v2: - remove modification about wsize because it has been fixed in commit c6cb3a2758 fs/ceph/super.c | 4 ++++ 1 file changed, 4 insertions(+)