| Message ID | 20190117231501.346447710@linutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | None | expand |
Thomas Gleixner <tglx@linutronix.de> writes: > Precise and non-ambiguous license information is important. The recently > added aegis header file has a SPDX license identifier, which is nice, but > at the same time it has a contradictionary license boiler plate text. > > SPDX-License-Identifier: GPL-2.0 > > versus > > * This program is free software; you can redistribute it and/or > * modify it under the terms of the GNU General Public License > * as published by the Free Software Foundation; either version 2 > * of the License, or (at your option) any later version. > > Oh well. > > As the other ceph related files are licensed under the GPL v2 only, it's > assumed that the SPDX id is correct and the boiler plate was randomly > copied into that patch. > > Remove the boiler plate as it is wrong and even if correct it is redundant. > > Fixes: fb18a57568c2 ("ceph: quota: add initial infrastructure to support cephfs quotas") > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > Cc: Luis Henriques <lhenriques@suse.com> > Cc: Jiri Kosina <jkosina@suse.cz> > Cc: "Yan, Zheng" <zyan@redhat.com> > Cc: Sage Weil <sage@redhat.com> > Cc: Ilya Dryomov <idryomov@gmail.com> > Cc: ceph-devel@vger.kernel.org Thanks, Thomas. Fell free to add my Acked-by: Luis Henriques <lhenriques@suse.com> Cheers,
On Fri, Jan 18, 2019 at 12:15 AM Thomas Gleixner <tglx@linutronix.de> wrote: > > Precise and non-ambiguous license information is important. The recently > added aegis header file has a SPDX license identifier, which is nice, but Looks like cut-and-paste from crypto/aegis.h patch? I'm changing this to say "recently added quota.c file". > at the same time it has a contradictionary license boiler plate text. > > SPDX-License-Identifier: GPL-2.0 > > versus > > * This program is free software; you can redistribute it and/or > * modify it under the terms of the GNU General Public License > * as published by the Free Software Foundation; either version 2 > * of the License, or (at your option) any later version. > > Oh well. > > As the other ceph related files are licensed under the GPL v2 only, it's > assumed that the SPDX id is correct and the boiler plate was randomly > copied into that patch. > > Remove the boiler plate as it is wrong and even if correct it is redundant. > > Fixes: fb18a57568c2 ("ceph: quota: add initial infrastructure to support cephfs quotas") > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > Cc: Luis Henriques <lhenriques@suse.com> > Cc: Jiri Kosina <jkosina@suse.cz> > Cc: "Yan, Zheng" <zyan@redhat.com> > Cc: Sage Weil <sage@redhat.com> > Cc: Ilya Dryomov <idryomov@gmail.com> > Cc: ceph-devel@vger.kernel.org > --- > > P.S.: This patch is part of a larger cleanup, but independent of other > patches and is intended to be picked up by the maintainer directly. > > --- > fs/ceph/quota.c | 13 ------------- > 1 file changed, 13 deletions(-) > > --- a/fs/ceph/quota.c > +++ b/fs/ceph/quota.c > @@ -3,19 +3,6 @@ > * quota.c - CephFS quota > * > * Copyright (C) 2017-2018 SUSE > - * > - * This program is free software; you can redistribute it and/or > - * modify it under the terms of the GNU General Public License > - * as published by the Free Software Foundation; either version 2 > - * of the License, or (at your option) any later version. > - * > - * This program is distributed in the hope that it will be useful, > - * but WITHOUT ANY WARRANTY; without even the implied warranty of > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > - * GNU General Public License for more details. > - * > - * You should have received a copy of the GNU General Public License > - * along with this program; if not, see <http://www.gnu.org/licenses/>. > */ > > #include <linux/statfs.h> Applied. Thanks, Ilya
On Fri, 18 Jan 2019, Ilya Dryomov wrote: > On Fri, Jan 18, 2019 at 12:15 AM Thomas Gleixner <tglx@linutronix.de> wrote: > > > > Precise and non-ambiguous license information is important. The recently > > added aegis header file has a SPDX license identifier, which is nice, but > > Looks like cut-and-paste from crypto/aegis.h patch? Oops, sorry. > I'm changing this to say "recently added quota.c file". Thank you! tglx
--- a/fs/ceph/quota.c +++ b/fs/ceph/quota.c @@ -3,19 +3,6 @@ * quota.c - CephFS quota * * Copyright (C) 2017-2018 SUSE - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU General Public License - * as published by the Free Software Foundation; either version 2 - * of the License, or (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, see <http://www.gnu.org/licenses/>. */ #include <linux/statfs.h>
Precise and non-ambiguous license information is important. The recently added aegis header file has a SPDX license identifier, which is nice, but at the same time it has a contradictionary license boiler plate text. SPDX-License-Identifier: GPL-2.0 versus * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License * as published by the Free Software Foundation; either version 2 * of the License, or (at your option) any later version. Oh well. As the other ceph related files are licensed under the GPL v2 only, it's assumed that the SPDX id is correct and the boiler plate was randomly copied into that patch. Remove the boiler plate as it is wrong and even if correct it is redundant. Fixes: fb18a57568c2 ("ceph: quota: add initial infrastructure to support cephfs quotas") Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Luis Henriques <lhenriques@suse.com> Cc: Jiri Kosina <jkosina@suse.cz> Cc: "Yan, Zheng" <zyan@redhat.com> Cc: Sage Weil <sage@redhat.com> Cc: Ilya Dryomov <idryomov@gmail.com> Cc: ceph-devel@vger.kernel.org --- P.S.: This patch is part of a larger cleanup, but independent of other patches and is intended to be picked up by the maintainer directly. --- fs/ceph/quota.c | 13 ------------- 1 file changed, 13 deletions(-)