Message ID | 20220606122425.316004-1-xiubli@redhat.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | ceph: fix the incorrect comment for the ceph_mds_caps struct | expand |
On Mon, 2022-06-06 at 20:24 +0800, Xiubo Li wrote: > The incorrect comment is misleading. Acutally the last members > in ceph_mds_caps strcut is a union for none export and export > bodies. > > Signed-off-by: Xiubo Li <xiubli@redhat.com> > --- > include/linux/ceph/ceph_fs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/ceph/ceph_fs.h b/include/linux/ceph/ceph_fs.h > index 86bf82dbd8b8..24622ecb9900 100644 > --- a/include/linux/ceph/ceph_fs.h > +++ b/include/linux/ceph/ceph_fs.h > @@ -768,7 +768,7 @@ struct ceph_mds_caps { > __le32 xattr_len; > __le64 xattr_version; > > - /* filelock */ > + /* a union of none export and export bodies. */ Also confusing :) I think you mean "a union of non-export and export bodies." > __le64 size, max_size, truncate_size; > __le32 truncate_seq; > struct ceph_timespec mtime, atime, ctime;
On 6/6/22 8:26 PM, Jeff Layton wrote: > On Mon, 2022-06-06 at 20:24 +0800, Xiubo Li wrote: >> The incorrect comment is misleading. Acutally the last members >> in ceph_mds_caps strcut is a union for none export and export >> bodies. >> >> Signed-off-by: Xiubo Li <xiubli@redhat.com> >> --- >> include/linux/ceph/ceph_fs.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/include/linux/ceph/ceph_fs.h b/include/linux/ceph/ceph_fs.h >> index 86bf82dbd8b8..24622ecb9900 100644 >> --- a/include/linux/ceph/ceph_fs.h >> +++ b/include/linux/ceph/ceph_fs.h >> @@ -768,7 +768,7 @@ struct ceph_mds_caps { >> __le32 xattr_len; >> __le64 xattr_version; >> >> - /* filelock */ >> + /* a union of none export and export bodies. */ > Also confusing :) > > I think you mean "a union of non-export and export bodies." Right. Will fix it :-) Thanks! >> __le64 size, max_size, truncate_size; >> __le32 truncate_seq; >> struct ceph_timespec mtime, atime, ctime;
diff --git a/include/linux/ceph/ceph_fs.h b/include/linux/ceph/ceph_fs.h index 86bf82dbd8b8..24622ecb9900 100644 --- a/include/linux/ceph/ceph_fs.h +++ b/include/linux/ceph/ceph_fs.h @@ -768,7 +768,7 @@ struct ceph_mds_caps { __le32 xattr_len; __le64 xattr_version; - /* filelock */ + /* a union of none export and export bodies. */ __le64 size, max_size, truncate_size; __le32 truncate_seq; struct ceph_timespec mtime, atime, ctime;
The incorrect comment is misleading. Acutally the last members in ceph_mds_caps strcut is a union for none export and export bodies. Signed-off-by: Xiubo Li <xiubli@redhat.com> --- include/linux/ceph/ceph_fs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)